From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x231.google.com (mail-oi1-x231.google.com [IPv6:2607:f8b0:4864:20::231]) by sourceware.org (Postfix) with ESMTPS id 3CEA33856954 for ; Mon, 5 Jun 2023 18:21:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3CEA33856954 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oi1-x231.google.com with SMTP id 5614622812f47-39a97058691so2209663b6e.2 for ; Mon, 05 Jun 2023 11:21:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685989297; x=1688581297; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=WoCWF5r1RxsUUezU9jrbE0aE6XGLbjWfm6uszgBZGHc=; b=G5o/S/99LzzjZQHi9IlnWg77kUu5/rgDD6uAwI9/9Njk/Ask0Km2hHjl1DKppX1rU5 ezz54B1c2AXHnm+gL1jwF9BIaBBNRR46zu8jxeRzzp6asKN05S6svrfAVhk9rFU7FWD6 Gw1hQATpXiDAN/LvJ5bv0UTk106BW8A4c3kTALBqmM4AkiBi4fYAvo3lrzfwkayoGPDY g6fyzORUEr7DIEQN+K4nrBfQS+qnHt/BlK//7JPgaDDtWF36gvCotRU0fG8y7SBE061p UrGy0pKeBNOrEnvbVVOZMQUSdWFMtgrOXDM9S1TihDBax4iMKOSbh6ED5pz4goh5frJc 5Bzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685989297; x=1688581297; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=WoCWF5r1RxsUUezU9jrbE0aE6XGLbjWfm6uszgBZGHc=; b=kmMGa5zf7Qvq4a3Noe/loEXuykY0RBA6ZIbif0nSz0PQ2iTub2r7b9+GLysYHXkR37 Papw4vNpRQ0khmEgH5RKRemGuXmzYuss5Bgp3WT8ZGfJUgSTHov0x2QYt1mW+KOTmwX/ EGCK32Q3a6zCigbPlRTDqm1lYC/xS3sFjufiWNVIeooNMdsyiQeqkfZgcNoGcJZmYLpE 7GsQqhRA1QaxfKAvT+LhadTxvkiH13mK0nFBi0IJS0E//zrOt8ip1BRqkBekS7V2NYiF 6UahDP5l8q+1C3km97YpazggfpoQA1OF0I1E9nHdvLqZpTHmhobnNqyUMq2b+8AQC8Zr Vfsw== X-Gm-Message-State: AC+VfDx2ljPvbELpRHAgciUjyQWuLqIS7n1TXVwLQuBk+SFO6gMdpGNQ xbRLQ+ctuHu6Pq0omdtA4PE3Cg== X-Google-Smtp-Source: ACHHUZ65SXTC9wFj/tHApzMIIBO78XR7eFOnhKIpMI2L89FNds7DQlbsKLg8HLLYEVwKx1qxlIElYw== X-Received: by 2002:a05:6808:234a:b0:39a:7830:f252 with SMTP id ef10-20020a056808234a00b0039a7830f252mr8189474oib.1.1685989297499; Mon, 05 Jun 2023 11:21:37 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:fe49:680c:a97a:ffe6:9a8f? ([2804:1b3:a7c1:fe49:680c:a97a:ffe6:9a8f]) by smtp.gmail.com with ESMTPSA id k17-20020a544691000000b0039a531d9b92sm3495854oic.56.2023.06.05.11.21.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Jun 2023 11:21:36 -0700 (PDT) Message-ID: <0b394c6a-93a2-09e8-7908-8a74b1d5a7a4@linaro.org> Date: Mon, 5 Jun 2023 15:21:34 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.2 Subject: Re: [PATCH] linux: Split tst-ttyname Content-Language: en-US To: Florian Weimer Cc: Adhemerval Zanella via Libc-alpha References: <20230601174432.456518-1-adhemerval.zanella@linaro.org> <87pm6ayqzq.fsf@oldenburg.str.redhat.com> <3d708678-6d74-b527-2e50-89255fcd65d1@linaro.org> <87zg5dydn4.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <87zg5dydn4.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.8 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 05/06/23 15:20, Florian Weimer wrote: > * Adhemerval Zanella Netto: > >> On 05/06/23 10:32, Florian Weimer wrote: >>> * Adhemerval Zanella via Libc-alpha: >>> >>>> sysdeps/unix/sysv/linux/Makefile | 1 + >>>> sysdeps/unix/sysv/linux/tst-ttyname-common.c | 416 ++++++++++++++ >>>> .../unix/sysv/linux/tst-ttyname-namespace.c | 147 +++++ >>>> sysdeps/unix/sysv/linux/tst-ttyname.c | 512 +----------------- >>>> 4 files changed, 567 insertions(+), 509 deletions(-) >>>> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-common.c >>>> create mode 100644 sysdeps/unix/sysv/linux/tst-ttyname-namespace.c >>> >>> I'd prefer if we could stop using the original tst-ttyname name for >>> clarity. >> >> Do you mean for the new tst-ttyname-namespace or for tst-ttyname as well? >> The test idea is really to check ttyname, so what exactly do you suggest >> us to change? > > We've seen quite a few reports about tst-ttyname failures, and it would > be nice if future reports would unambiguously refer to the split test. > So perhaps tst-ttyname-direct? Ah right, sounds reasonable.