From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x230.google.com (mail-oi1-x230.google.com [IPv6:2607:f8b0:4864:20::230]) by sourceware.org (Postfix) with ESMTPS id 0D2AA385840C for ; Fri, 28 Jan 2022 16:41:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D2AA385840C Received: by mail-oi1-x230.google.com with SMTP id p203so13281464oih.10 for ; Fri, 28 Jan 2022 08:41:26 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=YI1GIekt3Th9e98XCR4RhFoOLEZEt5apX77Fj3bcaX0=; b=rnBF/OuA9SQz+eAeTulUPM1tvECUwwlFG8rsrUTsZLX9owxlssuZlhGmmwrKApKRK0 C6k2sdKwwlDZtzMpzj2rr9ZpGS6nedSJdNeerdQ/5iPHGqPy/FfGDp4Qfk18lW4fKtpn htLWLKaLXOWISB0WBNHuV15Y4x+BukaDYSmC51hAcoOhVKITPLtyx8nBIUPcJZEWa8ON 55wCtZxdyyVataH5tBYmQbnCiOUrdrSiYRSe+F5Qaxl8eOfHTmM5UtkkjEtMAh1RoDqw L/2Xj1UE0TWS10SckDqCxVj4t1axMBK6dGhHxM1iQSbRg+92bGHIPxfJVCgjzUsLVjxz LNEQ== X-Gm-Message-State: AOAM531sU8kUeQLQNa8fJNST6Ik0/kRDWoQ3/YxTSlV4pC4Z2WepKR7j ZPbfbwPPRIsCzBuvNvz6FJEw9w== X-Google-Smtp-Source: ABdhPJy6j9dKIDYvSjVrQVNotUmsHTnm3N/l1bj7sHfs/DI7uwaU7RyD0/ANEF97XEIq9aE8ATuiag== X-Received: by 2002:aca:38c6:: with SMTP id f189mr5598053oia.275.1643388085467; Fri, 28 Jan 2022 08:41:25 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:709a:aad4:4e8:bc05:17ad? ([2804:431:c7ca:709a:aad4:4e8:bc05:17ad]) by smtp.gmail.com with ESMTPSA id c21sm4822303oto.55.2022.01.28.08.41.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Jan 2022 08:41:25 -0800 (PST) Message-ID: <0b51c03b-cccd-1ab2-dae1-ac229a448a72@linaro.org> Date: Fri, 28 Jan 2022 13:41:22 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.1 Subject: Re: [PATCH v5 2/3] linux: Fix ancillary 64-bit time timestamp conversion (BZ #28349, BZ#28350) Content-Language: en-US To: Florian Weimer Cc: libc-alpha@sourceware.org, Carlos O'Donell , Fabian Vogt References: <20220127201542.2306657-1-adhemerval.zanella@linaro.org> <20220127201542.2306657-3-adhemerval.zanella@linaro.org> <87r18sj8pm.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <87r18sj8pm.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Jan 2022 16:41:28 -0000 On 28/01/2022 10:22, Florian Weimer wrote: > * Adhemerval Zanella: > >> + /* If there is no timestamp in the ancillary data, recvmsg should set >> + the flag to indicate it. */ > > I think this comment is outdated. The rest looks okay to me. Indeed, I though I had removed all the outdated comments. > > Reviewed-by: Florian Weimer Thanks. > > Thanks, > Florian >