From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 61120 invoked by alias); 1 Nov 2016 17:17:13 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 61106 invoked by uid 89); 1 Nov 2016 17:17:12 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=IPC, Hx-languages-length:1300 X-HELO: mail-vk0-f42.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding; bh=fCGtMSMxSgRHNrrJutrK3y28ljKM5c9h7kBYHWRe6FQ=; b=HVwkq4NOhmdG4vylA9dShcexSsrVgd3eOKjwHS5MrawIPYm60i7EfLdlshDbSg8wg6 LHMX2jHetBRrjgKRpdvT6gHXt+GN17EPIe4PFNX4xtLnb6VxMLH3GG2A3yGIK5WrRo72 AqwXmIULE8WH7JIObtgw18IOZA2LTORK1c5pbrLOdhP3Oc6vNQNugVfU4qFmDwuh5fwh NPdHUUyMLNn1mDCln7UR2vA/4tPIxW7t0c0TAe1JU3s5fjDUsr5eRSGOpjAFhyP1ePI9 U9JsL5FlKtTNB1rh8twB7iJAE1RifXz14L6HI5kDL0XN8McfNijZAPItlRzV+Men+neG SXBA== X-Gm-Message-State: ABUngvfaEKY1dqAAcZgiP5WuOY9JVk7HcQgADvSHXyKRemMUNGb+OWMGclq119beyWyH1I4G X-Received: by 10.31.141.5 with SMTP id p5mr28783670vkd.136.1478020620319; Tue, 01 Nov 2016 10:17:00 -0700 (PDT) Subject: Re: [PATCH 07/15] Use semget syscall for Linux implementation To: Joseph Myers , Andreas Schwab References: <1478010323-13076-1-git-send-email-adhemerval.zanella@linaro.org> <1478010323-13076-8-git-send-email-adhemerval.zanella@linaro.org> <87bmxzw6wn.fsf@linux-m68k.org> Cc: libc-alpha@sourceware.org From: Adhemerval Zanella Message-ID: <0b9aa220-370a-a196-8640-a65b46b3c344@linaro.org> Date: Tue, 01 Nov 2016 17:17:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00039.txt.bz2 On 01/11/2016 14:40, Joseph Myers wrote: > On Tue, 1 Nov 2016, Andreas Schwab wrote: > >> On Nov 01 2016, Adhemerval Zanella wrote: >> >>> This patch add a direct call to semget syscall if it is defined by >>> kernel headers. >> >> That does not mean that the running kernel provides it. > > Specifically, this sort of patch series needs to be accompanied by an > analysis of when the relevant syscalls were added for each supported > architecture (and subarchitecture for cases with multiple syscall tables > for different ABNs). If present (in the syscall table as well as in > asm/unistd.h) in the minimum kernel version, OK, otherwise you need > appropriate __ASSUME_* conditionals (even if not present in the latest > kernel, it might be added in future, so you should have those conditionals > now to avoid breaking things when current glibc is compiled with future > kernel headers). Indeed, I did not consider the case of latest kernel headers. Based on current Linux approach and historical implementation for sysv IPC I think we can assume that either the kernel only supports the old 'ipc' syscall or all the sysvipc syscall wire-up. Do you know if we do require an __ASSUME for each syscall?