From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120363 invoked by alias); 18 Oct 2018 10:38:20 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 120179 invoked by uid 89); 18 Oct 2018 10:38:18 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=AWL,BAYES_00,KHOP_DYNAMIC,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=no version=3.3.2 spammy=2.29, Hx-languages-length:1035 X-HELO: mx0a-001b2d01.pphosted.com Subject: [COMMITTED 2.27 / 2.28] Fix race in pthread_mutex_lock while promoting to PTHREAD_MUTEX_ELISION_NP [BZ #23275] To: libc-stable@sourceware.org References: <874ldm3v09.fsf@oldenburg.str.redhat.com> <20603cf9-6427-d7da-8bf6-b2eed6abb61a@linux.ibm.com> Cc: libc-alpha@sourceware.org, Florian Weimer From: Stefan Liebler Date: Thu, 18 Oct 2018 13:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20603cf9-6427-d7da-8bf6-b2eed6abb61a@linux.ibm.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit x-cbid: 18101810-0016-0000-0000-00000214E0AD X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 18101810-0017-0000-0000-0000326C8180 Message-Id: <0b9dbba4-26d0-e87d-086c-9705c10ef46c@linux.ibm.com> X-SW-Source: 2018-10/txt/msg00326.txt.bz2 On 10/17/2018 12:28 PM, Stefan Liebler wrote: > On 10/16/2018 03:01 PM, Florian Weimer wrote: >> * Stefan Liebler: >> >>> The flag PTHREAD_MUTEX_NO_ELISION_NP is not explicitly checked before >>> FORCE_ELISION is called. But only one of those two flags can be set. >>> Your remaining assumption is correct. >>> I've changed the comment in the three force-elision.h files. Is this >>> okay? >> >> The comment looks good to me know.  Thanks! >> >> Florian >> > Committed, bugzilla closed and target milestone is set to 2.29. > > Thanks, > Stefan > Starting with glibc 2.27, the configure switch --enable-lock-elision was removed with commit "Add elision tunables" (https://sourceware.org/git/?p=glibc.git;a=commit;h=07ed18d26a342741cb25a4739158c65ed9dd4d09). Now you can use lock-elision by just setting the tunables environment variable. Therefore I've cherry picked this patch to release branch 2.27 / 2.28. Bye Stefan