From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: Andrew Pinski <pinskia@gmail.com>
Cc: GNU C Library <libc-alpha@sourceware.org>,
Wilco Dijkstra <Wilco.Dijkstra@arm.com>,
Szabolcs Nagy <szabolcs.nagy@arm.com>
Subject: Re: [PATCH 3/3] aarch64: Hoist ZVA check out of the memset function
Date: Thu, 09 Nov 2017 05:45:00 -0000 [thread overview]
Message-ID: <0bb0752d-cfa7-5b4a-ad97-d2580e103e14@sourceware.org> (raw)
In-Reply-To: <CA+=Sn1=MCd=JsNZwaHkRJ2j-kgKWKkxHdSskuSfi4dLd=2N96Q@mail.gmail.com>
On Thursday 09 November 2017 10:59 AM, Andrew Pinski wrote:
> I don't like this at all for the increase file size for the not so
> significant gain on real platforms. I think we should declare falkor
> micro-arch is broken and move on.
Are you sure this doesn't give any gains for thunderx for the sizes I
mentioned (256B - ~1K)? I see significant gains on mustang too and it
is obvious to see why; it is 3 instructions and a branch less in a hot
path and that should be significant regardless of the MRS cost.
If you don't see any gain then I don't mind posting this as a
falkor-specific change. If you change your mind in future we can always
change the IFUNC condition.
Siddhesh
next prev parent reply other threads:[~2017-11-09 5:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-09 5:13 [PATCH 0/3] memset zva optimization Siddhesh Poyarekar
2017-11-09 5:14 ` [PATCH 1/3] benchtests: Fix walking sizes and directions for *-walk benchmarks Siddhesh Poyarekar
2017-11-14 9:18 ` Siddhesh Poyarekar
2017-11-20 12:34 ` Siddhesh Poyarekar
2017-11-09 5:14 ` [PATCH 3/3] aarch64: Hoist ZVA check out of the memset function Siddhesh Poyarekar
2017-11-09 5:33 ` Andrew Pinski
2017-11-09 5:45 ` Siddhesh Poyarekar [this message]
2017-11-09 5:46 ` Andrew Pinski
2017-11-09 5:59 ` Siddhesh Poyarekar
2017-11-09 5:14 ` [PATCH 2/3] benchtests: Bump start size since smaller sizes are noisy Siddhesh Poyarekar
2017-11-14 9:19 ` Siddhesh Poyarekar
2017-11-20 12:34 ` Siddhesh Poyarekar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0bb0752d-cfa7-5b4a-ad97-d2580e103e14@sourceware.org \
--to=siddhesh@sourceware.org \
--cc=Wilco.Dijkstra@arm.com \
--cc=libc-alpha@sourceware.org \
--cc=pinskia@gmail.com \
--cc=szabolcs.nagy@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).