public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Siddhesh Poyarekar <siddhesh@sourceware.org>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [Patch v2] malloc: Clean up __malloc_initialized
Date: Tue, 22 Jun 2021 10:17:56 +0530	[thread overview]
Message-ID: <0c0f92f6-70ae-b947-8713-34b1b3491313@sourceware.org> (raw)
In-Reply-To: <20210618095351.1557461-1-siddhesh@sourceware.org>

On 6/18/21 3:23 PM, Siddhesh Poyarekar via Libc-alpha wrote:
> It can be assumed that ptmalloc_init is always called in a
> single-threaded context because pthread_create calls malloc before
> spawning a thread.  As a result, a boolean value for
> __malloc_initialized is sufficient to ensure that the function body is
> executed only once.
> 
> Further, __malloc_initialized is mentioned in Versions when it is
> actually an internal symbol.  Drop that reference and the macro
> definition to __libc_malloc_initialized since it does not have an
> external use.
> ---
> Changes from v1:
> - Retained attribute_hidden extern declaration.


Florian what do you think?  I've made the change you requested.

Siddhesh

  reply	other threads:[~2021-06-22  4:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-18  9:09 [PATCH] " Siddhesh Poyarekar
2021-06-18  9:36 ` Florian Weimer
2021-06-18  9:53   ` [Patch v2] " Siddhesh Poyarekar
2021-06-22  4:47     ` Siddhesh Poyarekar [this message]
2021-06-22 12:46     ` Siddhesh Poyarekar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0c0f92f6-70ae-b947-8713-34b1b3491313@sourceware.org \
    --to=siddhesh@sourceware.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).