From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x32.google.com (mail-oa1-x32.google.com [IPv6:2001:4860:4864:20::32]) by sourceware.org (Postfix) with ESMTPS id ED85B38582A7 for ; Wed, 21 Sep 2022 14:02:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED85B38582A7 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x32.google.com with SMTP id 586e51a60fabf-1274ec87ad5so9273585fac.0 for ; Wed, 21 Sep 2022 07:02:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=rc3PTrZnPRyMBpofTtdCVeuFwJHiCUGqKwqIHLD7do0=; b=gdjw8i56rDdbYUdqMzfhoHa8XXCrhuwJvEZPXaV/JRYLRpS2dpxgdDUV6jCNGZh3Y6 ZoqIGZDMQYXflqucSNK2+Ybv9HpMEN5DjvMuUzCQxhUht+zciho6eLRvoYlE38dZg8o8 icP4ZlVq7Xf1MgSKVwi8kUGBU6G2wa1kdsDj68PWKjWI0X/oTVG/UB42ONiGGEeZIvYz ZrcLnUrETtAhyHagNWbgYS3MJ6pkWSw8/R1TISLIkK6y8G4lL7ugYlYYVnF0tmCiADGL ka+/k9kcLGfd8CNnmlbDtg0GvztSYIIPtu/EymiZXjh+WWMyd8nvhUKRqvV0euuRKvfJ MBSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=rc3PTrZnPRyMBpofTtdCVeuFwJHiCUGqKwqIHLD7do0=; b=YS/KZUAiT/SA/HEK/28rLiop9FGfbtUnTpgu1KRZYBTlwQCtKm7aj/2dY/B9FIz72K ykwQ6k6WBi5v7zu10ERdDmtvR3IFpIN0fRgQtVpw0/ZwLNHjw3gCsnMOiDYJBrInxD4c bZ10ve5eTv+qP2NhJhzo3vP/0vAfkXRNgdoQQZEE1uLF/qrFbLXA/gPalXXFFwLMfAAR QEyrO3Z/x0qiPXg2SvUaKzUa411KlUtmNiskS1+CfYArYi/ylHdBR019zCdAuuBO60q3 KneC0HApXCK9lm0nD1+sH1OBtj8grJgl1hTiwo5qR02HdD2Rd/2dk7v7W/XxslioYYMS qLxg== X-Gm-Message-State: ACrzQf1FtjfIrczM8k54aOI2v6xAFJB9y+qy/nVTqgUuXqN4l7BcT0sz +J3Okhd2GtpPp1xDrYwquDAHNA== X-Google-Smtp-Source: AMsMyM75+4iedduSdR7qi5STnuB3wg9qkhakqEf4l1fYIBzlacybWp4IHM7g81uGLbBYHm+vVU9dEg== X-Received: by 2002:a05:6870:899d:b0:12b:cdce:63d5 with SMTP id f29-20020a056870899d00b0012bcdce63d5mr5113782oaq.51.1663768921330; Wed, 21 Sep 2022 07:02:01 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:c266:cc93:9f8:1eba:d2e8? ([2804:1b3:a7c1:c266:cc93:9f8:1eba:d2e8]) by smtp.gmail.com with ESMTPSA id c18-20020a056830001200b0065a193c08absm1337633otp.34.2022.09.21.07.02.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Sep 2022 07:02:00 -0700 (PDT) Message-ID: <0cc18285-5472-54f1-a83a-8aa5cbe1985b@linaro.org> Date: Wed, 21 Sep 2022 11:01:58 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v3] elf: Use C11 atomics on _dl_mcount Content-Language: en-US To: Wilco Dijkstra , "libc-alpha@sourceware.org" References: <20220920190413.3160597-1-adhemerval.zanella@linaro.org> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.2 required=5.0 tests=BAYES_00,BODY_8BITS,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 20/09/22 19:59, Wilco Dijkstra wrote: > Hi Adhemerval, > > > @@ -558,14 +558,14 @@ _dl_mcount (ElfW(Addr) frompc, ElfW(Addr) selfpc) >            /* If we still have no entry stop searching and insert.  */ >            if (*topcindex == 0) >              { > -             unsigned int newarc = catomic_exchange_and_add (narcsp, 1); > +             unsigned int newarc = atomic_fetch_add_relaxed (narcsp, 1) + 1; >   > This adds a spurious + 1. Other than that it looks good to me. Thanks, I have removed it. > > Reviewed-by: Wilco Dijkstra > > Cheers, > Wilco