From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>, libc-alpha@sourceware.org
Subject: Re: [PATCH 5/5] de_DE: Convert to UTF-8
Date: Mon, 4 Jul 2022 15:54:24 -0400 [thread overview]
Message-ID: <0cdfe127-e087-bc13-45d2-d4c4a59d0fcf@redhat.com> (raw)
In-Reply-To: <8faf1d5dc7508a17bd14005b54f89593667aeecb.1652994079.git.fweimer@redhat.com>
On 5/19/22 17:06, Florian Weimer via Libc-alpha wrote:
> ---
I appreciate that you did a test conversion!
LGTM.
Reviewed-by: Carlos O'Donell <carlos@redhat.com>
Tested-by: Carlos O'Donell <carlos@redhat.com>
> localedata/locales/de_DE | 32 ++++++++++++++++----------------
> 1 file changed, 16 insertions(+), 16 deletions(-)
>
> diff --git a/localedata/locales/de_DE b/localedata/locales/de_DE
> index 49a421fff4..52767808f7 100644
> --- a/localedata/locales/de_DE
> +++ b/localedata/locales/de_DE
> @@ -46,36 +46,36 @@ include "translit_combining";""
>
> % German umlauts.
> % LATIN CAPITAL LETTER A WITH DIAERESIS.
> -<U00C4> "A<U0308>";"AE"
> +Ä "Ä";"AE"
> % LATIN CAPITAL LETTER O WITH DIAERESIS.
> -<U00D6> "O<U0308>";"OE"
> +Ö "Ö";"OE"
> % LATIN CAPITAL LETTER U WITH DIAERESIS.
> -<U00DC> "U<U0308>";"UE"
> +Ü "Ü";"UE"
> % LATIN SMALL LETTER A WITH DIAERESIS.
> -<U00E4> "a<U0308>";"ae"
> +ä "ä";"ae"
> % LATIN SMALL LETTER O WITH DIAERESIS.
> -<U00F6> "o<U0308>";"oe"
> +ö "ö";"oe"
> % LATIN SMALL LETTER U WITH DIAERESIS.
> -<U00FC> "u<U0308>";"ue"
> +ü "ü";"ue"
>
> % Danish.
> % LATIN CAPITAL LETTER A WITH RING ABOVE.
> -<U00C5> "A<U030A>";"AA"
> +Å "Å";"AA"
> % LATIN SMALL LETTER A WITH RING ABOVE.
> -<U00E5> "a<U030A>";"aa"
> +å "å";"aa"
>
> % The following strange first-level transliteration derive from the use
> % U201E and U201C as "correct" quoting characters. These two characters
> % do not really belong together. The result is that somebody who uses
> % U201C and U201D will get the incorrect U00AB / U00BB sequences.
> % LEFT DOUBLE QUOTATION MARK
> -<U201C> <U00AB>;<U0022>
> +“ «;<U0022>
> % RIGHT DOUBLE QUOTATION MARK
> -<U201D> <U00BB>;<U0022>
> +” »;<U0022>
> % DOUBLE LOW-9 QUOTATION MARK
> -<U201E> <U00BB>;"<U002C><U002C>"
> +„ »;",,"
> % DOUBLE HIGH-REVERSED-9 QUOTATION MARK
> -<U201F> <U00AB>;<U0022>
> +‟ «;<U0022>
>
> translit_end
>
> @@ -90,7 +90,7 @@ END LC_COLLATE
>
> LC_MONETARY
> int_curr_symbol "EUR "
> -currency_symbol "<U20AC>"
> +currency_symbol "€"
> mon_decimal_point ","
> mon_thousands_sep "."
> mon_grouping 3;3
> @@ -126,14 +126,14 @@ day "Sonntag";/
> "Freitag";/
> "Samstag"
> abmon "Jan";"Feb";/
> - "M<U00E4>r";"Apr";/
> + "Mär";"Apr";/
> "Mai";"Jun";/
> "Jul";"Aug";/
> "Sep";"Okt";/
> "Nov";"Dez"
> mon "Januar";/
> "Februar";/
> - "M<U00E4>rz";/
> + "März";/
> "April";/
> "Mai";/
> "Juni";/
> @@ -172,7 +172,7 @@ END LC_PAPER
>
> LC_NAME
> name_fmt "%d%t%g%t%m%t%f"
> -name_miss "Fr<U00E4>ulein"
> +name_miss "Fräulein"
> name_mr "Herr"
> name_mrs "Frau"
> name_ms "Frau"
--
Cheers,
Carlos.
next prev parent reply other threads:[~2022-07-04 19:54 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-19 21:06 [PATCH 0/5] Assume UTF-8 encoding for localedef input files Florian Weimer
2022-05-19 21:06 ` [PATCH 1/5] locale: Turn ADDC and ADDS into functions in linereader.c Florian Weimer
2022-07-04 19:54 ` Carlos O'Donell
2022-05-19 21:06 ` [PATCH 2/5] locale: Fix signed char bug in lr_getc Florian Weimer
2022-07-04 19:54 ` Carlos O'Donell
2022-05-19 21:06 ` [PATCH 3/5] locale: Introduce translate_unicode_codepoint into linereader.c Florian Weimer
2022-07-04 19:54 ` Carlos O'Donell
2022-05-19 21:06 ` [PATCH 4/5] locale: localdef input files are now encoded in UTF-8 Florian Weimer
2022-07-04 19:54 ` Carlos O'Donell
2022-05-19 21:06 ` [PATCH 5/5] de_DE: Convert to UTF-8 Florian Weimer
2022-07-04 19:54 ` Carlos O'Donell [this message]
2022-07-05 9:27 ` Andreas Schwab
2022-07-05 9:55 ` Florian Weimer
2022-07-05 10:38 ` Andreas Schwab
2022-07-04 19:54 ` [PATCH 0/5] Assume UTF-8 encoding for localedef input files Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0cdfe127-e087-bc13-45d2-d4c4a59d0fcf@redhat.com \
--to=carlos@redhat.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).