From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x31.google.com (mail-oa1-x31.google.com [IPv6:2001:4860:4864:20::31]) by sourceware.org (Postfix) with ESMTPS id 2110A3858430 for ; Tue, 26 Apr 2022 13:19:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2110A3858430 Received: by mail-oa1-x31.google.com with SMTP id 586e51a60fabf-e93ff05b23so6199096fac.9 for ; Tue, 26 Apr 2022 06:19:14 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=lGIxJFyoaiGEFbvWs3IMLv9KhcLyvgoGF3NJsHfcpFc=; b=XRTzr2a9n73AANpl0/LwVMF3qEoyyC7h8w3IpbYnCqC6yo5XMUxK60z9DDa7jnN9zd Ppieo3q72088BP8zO9JvUhS/8AD73agNCM0GXV2YvmMOLmAam3BqWOHFMaJxb9McM/hJ 2/Tj80A/bpk6+UQem525BOvEyQ/hiPIAIUjEOHl+Lq8xHuGdQu6PNq8uEbPXKJOOp+H/ QgneTWc6eI1nlpZcRPnrofw3LcEMasMCVWM3JmKbGlkDDgV9aZ8hjEP/72ZdpYVS+FR4 7X04dAIS5E97lIOskULp/g3Pl0HHdVBmWJlOtz1nTg+fmzL5WynITav5OhDG/my/ODSh CRsQ== X-Gm-Message-State: AOAM533z/Cmx1+NY4pSIIaxeZuvaa5ZW3FZDIkNgIlvP4L768snr2eAZ JTwCJiiVSnePSRLgiGVW/c83Ag== X-Google-Smtp-Source: ABdhPJxMWO0aYyHWW71wiquJDD5cQh6jBlZdHSe3b06Dyh/4QZcYF6kllRR356CSytY4vygwjLt0aw== X-Received: by 2002:a05:6870:f20e:b0:e1:c609:74d8 with SMTP id t14-20020a056870f20e00b000e1c60974d8mr12896235oao.34.1650979152019; Tue, 26 Apr 2022 06:19:12 -0700 (PDT) Received: from ?IPV6:2804:431:c7ca:4214:1cb8:b955:7538:328c? ([2804:431:c7ca:4214:1cb8:b955:7538:328c]) by smtp.gmail.com with ESMTPSA id k124-20020aca3d82000000b002ef4c5bb9dbsm4780484oia.0.2022.04.26.06.19.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 26 Apr 2022 06:19:11 -0700 (PDT) Message-ID: <0d2567ed-b4e0-9063-2cd9-bd38924fb8ad@linaro.org> Date: Tue, 26 Apr 2022 10:19:08 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH] scripts/glibcelf.py: Mark as UNSUPPORTED on Python 3.5 and earlier Content-Language: en-US To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <875yn1rpdy.fsf@oldenburg.str.redhat.com> <87fsm1r5ry.fsf@oldenburg.str.redhat.com> <874k2gna9c.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: <874k2gna9c.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Apr 2022 13:19:16 -0000 On 25/04/2022 18:06, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> On 25/04/2022 04:17, Florian Weimer via Libc-alpha wrote: >>> * Florian Weimer: >>> >>>> enum.IntFlag and enum.EnumMeta._missing_ support is not present in those >>>> Python versions. >>>> >>>> --- >>>> scripts/glibcelf.py | 6 ++++++ >>>> 1 file changed, 6 insertions(+) >>>> >>>> diff --git a/scripts/glibcelf.py b/scripts/glibcelf.py >>>> index 8f7d0ca184..da0d5380f3 100644 >>>> --- a/scripts/glibcelf.py >>>> +++ b/scripts/glibcelf.py >>>> @@ -28,6 +28,12 @@ import collections >>>> import enum >>>> import struct >>>> >>>> +if not hasattr(enum, 'IntFlag'): >>>> + import sys >>>> + sys.stdout.write( >>>> + 'warning: glibcelf.py needs Python 3.6 for enum support\n') >>>> + sys.exit(77) >>>> + >>>> class _OpenIntEnum(enum.IntEnum): >>>> """Integer enumeration that supports arbitrary int values.""" >>>> @classmethod >>> >>> I've pushed this, to avoid masking other failures in Joseph's tester. >> >> We still indicate that Python 3.4 is supported on INSTALL. I think we >> should either update it or add a fallback code on glibcelf.py. > > Tests using scripts/glibcelf.py are marked as UNSUPPORTED. Isn't this > sufficient for now? > > We can say that Python 3.6 or later is recommended for full test > coverage. It would be good to have it proper documented yes, but would be possible to adapt the glibcelf.py to work with Python 3.4? So there will be no need to have to document that we support two different minor Python versions where if you use the older one you will have less test coverage (which I think it is not ideal).