From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from crocodile.elm.relay.mailchannels.net (crocodile.elm.relay.mailchannels.net [23.83.212.45]) by sourceware.org (Postfix) with ESMTPS id 0FE473858D28 for ; Fri, 11 Aug 2023 17:38:47 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0FE473858D28 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gotplt.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C68658012CF; Fri, 11 Aug 2023 17:38:46 +0000 (UTC) Received: from pdx1-sub0-mail-a316.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id E7D97802056; Fri, 11 Aug 2023 17:38:45 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1691775525; a=rsa-sha256; cv=none; b=qXzSn2maSZ6e347vs9u8r5w5ECiBRSiceEAyMpoSRMEBcXn9Dxy0NTBcrgnkNvfZSg3PXU MbW1shtB3DLPP7PzsCMak8l01rJNwQOr8++KRow5ezucqMtqHb1RbPD0X4pxpDKOcGt1yt iH/ElXaASuuoxqMNM1/c2ZZP3xGZpClLYN6hRjJeZ8oMcmW8czOj8j1rvLOTrQdyDiC/9V JHBHsIWZZ5yxHkUB6qq2n8lp/yiWdd7FCpK9vr91Pk9BGHEtO3VESSi6dwccilFstKlLWa xvJptQqZR0JUPMz8BdTOsSjJA6dPS/1v9Ned6RG6elmw5xG32tDANYrEXHR7vw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1691775525; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pM0CAupAAC4NHpUDgnphg6B84uucCWliXOPjBjcEcTw=; b=qJSJJ7vNFXu7mhzhnKeIJEgp/RHpjhE9GOIs1EM/ET5gPmeHYzplLjBwfKxsrmsZRVJ3eR SzZNYfWvriFnP+hEEb3491HipoR3Zr7R0BYLbZDkHiWma7CV9vYPC5WSlLygFeXgZ3ORvw WoOv+2T13eStez0ZmXZPGkGMOw6ZC2vprRrcjfYrxx33xfaiZlnaaTjr9JwhvmmlWZ1xNt clfMueoXbVIjZ+DSJobPoJUE/4conzw4zbGswSBZZhmwIcrNM17Jnz8myNN9IxxyfCztSD j2ltZ0rlrJsHGGEH/88R2lMJ+22Ei87NSx7ukPqsS204UCJ12gnjGf7RFnED7w== ARC-Authentication-Results: i=1; rspamd-749bd77c9c-zgwsd; auth=pass smtp.auth=dreamhost smtp.mailfrom=siddhesh@gotplt.org X-Sender-Id: dreamhost|x-authsender|siddhesh@gotplt.org X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|siddhesh@gotplt.org X-MailChannels-Auth-Id: dreamhost X-Spot-Grain: 52c7bfe34fb14346_1691775526652_553415255 X-MC-Loop-Signature: 1691775526652:3627322202 X-MC-Ingress-Time: 1691775526651 Received: from pdx1-sub0-mail-a316.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.121.110.70 (trex/6.9.1); Fri, 11 Aug 2023 17:38:46 +0000 Received: from [192.168.224.119] (unknown [24.114.54.40]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: siddhesh@gotplt.org) by pdx1-sub0-mail-a316.dreamhost.com (Postfix) with ESMTPSA id 4RMrch75PLzP7; Fri, 11 Aug 2023 10:38:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gotplt.org; s=dreamhost; t=1691775525; bh=pM0CAupAAC4NHpUDgnphg6B84uucCWliXOPjBjcEcTw=; h=Date:Subject:To:From:Content-Type:Content-Transfer-Encoding; b=RKGtdVLr/m3fkgy7b6d94Q0tR5imO8RykzDww/XN6FGzd6td3sWlnPv1SI/v5B2ao 5MduVi5Jyq+d0B8sg4cqI7kU7X0Ux458oVeVvdo7AghmHB5YYDJy9IJGQE8wrmbZWB hPp4cI4KbgHpI1LZB+RRaBxErl8Mj2G0tU9mXmQR0SBwM9k1zKwwIxJe2fpMCrNlqQ /ywAUN1DbibHjJGM7iutBV+aXw2ty958mOJkSutrxGfE/3IkUQ1JyJkQzKmGrLBgED jByOLyL79I5r46Y3bK4LQ0BI7eCIXA1w26IYo1Xx1377+eNrGwbCqHulnvs5Hy6F9W tIgkdiz3Y/Pig== Message-ID: <0d35873a-4a33-f827-041e-f6a13f4c9acd@gotplt.org> Date: Fri, 11 Aug 2023 13:38:43 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v2] resolv/nss_dns/dns-host: Get rid of alloca. Content-Language: en-US To: Joe Simmons-Talbott , libc-alpha@sourceware.org References: <20230810155738.2645097-1-josimmon@redhat.com> From: Siddhesh Poyarekar In-Reply-To: <20230810155738.2645097-1-josimmon@redhat.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3036.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2023-08-10 11:57, Joe Simmons-Talbott via Libc-alpha wrote: > Since the alloca is a small constant size use an array instead. > --- > Changes to v1: > * Use sizeof (tmp) rather than NS_MAXDNAME > resolv/nss_dns/dns-host.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/resolv/nss_dns/dns-host.c b/resolv/nss_dns/dns-host.c > index 1d60c51f5e..c8b77bbc35 100644 > --- a/resolv/nss_dns/dns-host.c > +++ b/resolv/nss_dns/dns-host.c > @@ -378,6 +378,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, > int *herrnop, int32_t *ttlp) > { > enum nss_status status = check_name (name, herrnop); > + char tmp[NS_MAXDNAME]; > if (status != NSS_STATUS_SUCCESS) > return status; > struct resolv_context *ctx = __resolv_context_get (); > @@ -395,8 +396,7 @@ _nss_dns_gethostbyname4_r (const char *name, struct gaih_addrtuple **pat, > */ > if (strchr (name, '.') == NULL) > { > - char *tmp = alloca (NS_MAXDNAME); You could keep tmp here, it doesn't have to go into the higher scope. > - const char *cp = __res_context_hostalias (ctx, name, tmp, NS_MAXDNAME); > + const char *cp = __res_context_hostalias (ctx, name, tmp, sizeof (tmp)); > if (cp != NULL) > name = cp; > }