From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-ot1-x333.google.com (mail-ot1-x333.google.com [IPv6:2607:f8b0:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 54027385841E for ; Mon, 17 Jan 2022 13:08:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 54027385841E Received: by mail-ot1-x333.google.com with SMTP id i5-20020a05683033e500b0057a369ac614so19631175otu.10 for ; Mon, 17 Jan 2022 05:08:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=ctJPFWxjb2e5ip7fsoTmXXLk1xyokFlxd14Z4mARR6w=; b=ri5uDe//AT0R705bljC7Zoqn3CyXMj+HZ5HNjEZfnpChnVk0wcXKJ982jV5izBgsjv G6h/zZIpOOWsa6/Be60fwT/nFxPEHiNtrf4rwBOjlN1rKLWhjVMNgPbLZVa8eGUsgtRx iY0K9F9FblmSqcqL69jMnr7R2KMMDOhihUTMpb+90eakcCc0c33alC7ZJgMFjreK8ccP 7JWLAtvDCU7WkFE88pnXEBZEan0gtDYqEF0jwZ3FjdZ0ny/kBDDu4d4EysnU3yxxrg0P RFeAPo39v7q7sl+ssV/XLHdRWjbMec3STFbLqYTzpTSwSh14OdiH+w/8kvBEC3c/MhJi bJHw== X-Gm-Message-State: AOAM533+E8/AqC/GGOYwgOG18/rkyewL9s4Ils1T8JOsG1tr1tXUV2on Lsr+hDpVoKuHRSNL0lJTd3INO9qV+Nmw1Q== X-Google-Smtp-Source: ABdhPJwB9MrlUZCV2/f5f2GhD+N1FfVNxIrNseue/q7KB1yWkGSQGlANqNJymgaXSJfWq01bt/ugGg== X-Received: by 2002:a9d:422:: with SMTP id 31mr11121997otc.296.1642424919409; Mon, 17 Jan 2022 05:08:39 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:989a:152:78c4:5eab:b8b5? ([2804:431:c7cb:989a:152:78c4:5eab:b8b5]) by smtp.gmail.com with ESMTPSA id z16sm5895559oih.50.2022.01.17.05.08.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 17 Jan 2022 05:08:39 -0800 (PST) Message-ID: <0d4040d0-3e5f-0c92-b4c2-9944b9668b1f@linaro.org> Date: Mon, 17 Jan 2022 10:08:36 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [glibc] elf: Fix 64 time_t support for installed statically binaries Content-Language: en-US To: Carlos O'Donell , Adhemerval Zanella , libc-alpha References: <20220112133028.A84B6393D035@sourceware.org> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 17 Jan 2022 13:08:44 -0000 On 14/01/2022 18:57, Carlos O'Donell wrote: > On 1/12/22 08:30, Adhemerval Zanella via Glibc-cvs wrote: >> https://sourceware.org/git/gitweb.cgi?p=glibc.git;h=0b8e83eb1455f3c0332eeb1f96fbc262fbd054e0 >> >> commit 0b8e83eb1455f3c0332eeb1f96fbc262fbd054e0 >> Author: Adhemerval Zanella >> Date: Wed Dec 29 10:20:46 2021 -0300 >> >> elf: Fix 64 time_t support for installed statically binaries >> >> The usage of internal static symbol for statically linked binaries >> does not work correctly for objects built with -D_TIME_BITS=64, >> since the internal definition does not provide the expected aliases. >> >> This patch makes it to use the default stat functions instead (which >> uses the default 64 time_t alias and types). >> >> Checked on i686-linux-gnu. > > Per the Monday patch queue review notes: > https://sourceware.org/pipermail/libc-alpha/2022-January/135137.html > > I was just going to review this when I noticed that it looks like you pushed what appears > to be 3 patches by accident, and then reverted 2 patches. > > You noted the accidental push here: > https://sourceware.org/pipermail/libc-alpha/2022-January/135208.html > Thank you! > > This patch was still pushed though. > > May I suggest you revert this for completeness and reapply with RB/TBs? Sorry about that, I will revert and reapply.