From: Xi Ruoyao <xry111@xry111.site>
To: dengjianbo <dengjianbo@loongson.cn>,
Richard Henderson <richard.henderson@linaro.org>,
libc-alpha@sourceware.org
Cc: adhemerval.zanella@linaro.org, caiyinyu@loongson.cn,
xuchenghua@loongson.cn, huangpei@loongson.cn
Subject: Re: [PATCH 3/3] Loongarch: Add ifunc support for strncmp{aligned, lsx}
Date: Tue, 22 Aug 2023 19:23:30 +0800 [thread overview]
Message-ID: <0d67b98f3b093a8e0eded89234164fbebcb7f9f7.camel@xry111.site> (raw)
In-Reply-To: <35f2640e67ab009e008a87782319a617bfaa9d03.camel@xry111.site>
On Tue, 2023-08-22 at 19:13 +0800, Xi Ruoyao via Libc-alpha wrote:
> On Tue, 2023-08-22 at 14:37 +0800, dengjianbo wrote:
>
> > Putting the data here is due to the performance. When the vld
> > instruction is executed, the data will be in the cache, it can
> > speed up the data loading.
>
> AFAIK LoongArch CPUs have separate icache and dcache like all modern
> CPUs, so this is not valid to me.
And even if it can really improve the performance, this is not on the
hot path of the algorithm so we should not use bizarre optimizations
here for marginal improvement.
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
next prev parent reply other threads:[~2023-08-22 11:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-22 2:11 [PATCH 0/3] Add ifunc support for str{nlen, cmp, ncmp} dengjianbo
2023-08-22 2:11 ` [PATCH 1/3] Loongarch: Add ifunc support for strnlen{aligned, lsx, lasx} dengjianbo
2023-08-22 2:11 ` [PATCH 2/3] Loongarch: Add ifunc support for strcmp{aligned, lsx} dengjianbo
2023-08-22 2:11 ` [PATCH 3/3] Loongarch: Add ifunc support for strncmp{aligned, lsx} dengjianbo
2023-08-22 3:56 ` Richard Henderson
2023-08-22 6:37 ` dengjianbo
2023-08-22 11:13 ` Xi Ruoyao
2023-08-22 11:23 ` Xi Ruoyao [this message]
2023-08-23 7:25 ` dengjianbo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0d67b98f3b093a8e0eded89234164fbebcb7f9f7.camel@xry111.site \
--to=xry111@xry111.site \
--cc=adhemerval.zanella@linaro.org \
--cc=caiyinyu@loongson.cn \
--cc=dengjianbo@loongson.cn \
--cc=huangpei@loongson.cn \
--cc=libc-alpha@sourceware.org \
--cc=richard.henderson@linaro.org \
--cc=xuchenghua@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).