public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: GNU C Library <libc-alpha@sourceware.org>,
	Vivek Das Mohapatra <vivek@collabora.com>
Subject: #pragma once usage
Date: Fri, 26 Feb 2021 16:10:44 -0300	[thread overview]
Message-ID: <0d9eceac-986e-2944-8c5e-bf25063229ad@linaro.org> (raw)

Reviewing the dlmopen shared patchset, it propose the use of '#pragma once' on
some tests header instead of include guards. I don't see an impending reason to
not use it, however I would like to check if there any issue I am not seeing.

Besides being non standard features, it also does not really fit our requirement
for exported headers, which usually add other headers and these check the include 
guards from 'parent' to emit an error if the these internal headers are included
directly.

However, I don't see why we can't start to use on glibc code itself (including
tests), at least to simplify some internal guards.  I haven't tested it, specially
on some headers that might be used on preprocessor mode to create constants by 
some scripts.

Is there any other issues that might prevent its internal usage?

             reply	other threads:[~2021-02-26 19:10 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-26 19:10 Adhemerval Zanella [this message]
2021-02-26 21:09 ` Zack Weinberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=0d9eceac-986e-2944-8c5e-bf25063229ad@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=vivek@collabora.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).