From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) by sourceware.org (Postfix) with ESMTPS id AF692385802A for ; Fri, 26 Feb 2021 19:10:53 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org AF692385802A Received: by mail-qt1-x832.google.com with SMTP id f17so7408975qth.7 for ; Fri, 26 Feb 2021 11:10:53 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language:content-transfer-encoding; bh=v0WlDbEhKxMbnvBo4E/3p61eB7K7Qf1/ATWFnQXy3/E=; b=CqRU9MQXM21AhI3wzPivS1LLcSAZlRg/pTekH0USbgu9MiO3gWJOtjqNdkHpl0ZbQv IODkAn0MtEMhiGaZd+AOVuhVi0nhy+iHk19VOSEz8aVwPwHG2itYKjycqWQBxb84+nOI r1ejEhnyffU/Ys+h7bUSAmSPrRakalWuAy7v99BKWsNr6xLtbNwFQij04p9IHx2r41Vq 5VBSaXN7SyoZtyEuiL02ufPyWL38VJuvb46yv/E0lb3+Vfg9/H/2hyUWDfyIzCNoXJO3 /1wbxTdDdNKMZj6huHQRh5Sn7S3ZJbYzdlBseSRL7zoD2MTKpp/b9DZq7z5LOoFPLoYM Jarg== X-Gm-Message-State: AOAM532FApU5AKJa/RrhKQUFQdGCgM0XHi0tScOq0lufDWShOhWMqetk kNVRmC5T+1Rb83CYa4/tdVXxpg== X-Google-Smtp-Source: ABdhPJwItyWKkaL6RhIwTmz11hL5pRzfb9VqG2P4vWtMT95/6AN3fRA2a2g4URYF4+FW5EBTMURt4w== X-Received: by 2002:aed:3965:: with SMTP id l92mr4100906qte.230.1614366648000; Fri, 26 Feb 2021 11:10:48 -0800 (PST) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id q15sm6906000qkm.126.2021.02.26.11.10.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 26 Feb 2021 11:10:47 -0800 (PST) To: GNU C Library , Vivek Das Mohapatra From: Adhemerval Zanella Subject: #pragma once usage Message-ID: <0d9eceac-986e-2944-8c5e-bf25063229ad@linaro.org> Date: Fri, 26 Feb 2021 16:10:44 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Feb 2021 19:10:55 -0000 Reviewing the dlmopen shared patchset, it propose the use of '#pragma once' on some tests header instead of include guards. I don't see an impending reason to not use it, however I would like to check if there any issue I am not seeing. Besides being non standard features, it also does not really fit our requirement for exported headers, which usually add other headers and these check the include guards from 'parent' to emit an error if the these internal headers are included directly. However, I don't see why we can't start to use on glibc code itself (including tests), at least to simplify some internal guards. I haven't tested it, specially on some headers that might be used on preprocessor mode to create constants by some scripts. Is there any other issues that might prevent its internal usage?