From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oo1-xc36.google.com (mail-oo1-xc36.google.com [IPv6:2607:f8b0:4864:20::c36]) by sourceware.org (Postfix) with ESMTPS id BFAB3385801F for ; Fri, 11 Feb 2022 12:47:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BFAB3385801F Received: by mail-oo1-xc36.google.com with SMTP id v17-20020a4ac911000000b002eac41bb3f4so10084117ooq.10 for ; Fri, 11 Feb 2022 04:47:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=dqjTdnaA5l3Id4I9cbQzcB5ryD2rGb6xSana1zztCwE=; b=YC4D0tos9cNVkzNKV1SOHFq6C028KWgjF1+sEPkrCoefoYBLYyyU3i+c9Lx2K1+10e 7de0gGoqqf9IeUkdg3QcEBo/jt/1WSR6X8flWZyaT3YteQxs6j/rlVPOezk10W46QxY+ GBST631BVaZ3WZZuB2DltipN2JKOgOUqgBGhEFovW2Zm5/rbbmyH2oJotn8PtjMrzDeZ r4VrK5+GZsog+PTdw7QeRZQMurUiPhPJqdN5WueqxvifOUzq7yCmH6sC5TkCSj/Fqzex kqHWvYAeHqbQxoEKeRFmJpg0R4PpDfj+0jVL5Wp4ZPmrs6+7pzVpJyfr3mznDw2ymw+E Ls2w== X-Gm-Message-State: AOAM533qKTnM0r51Zw9BKjd/l3r+xaKa2Lw2+OZWyiI+L/wMoq5+4uXw yGPTPWIGzffXkXiMG9DSJZvy0w== X-Google-Smtp-Source: ABdhPJwDFDvHsu08fLYlNHGFNKjLdqnBU4CTLYDeCTEp3idrcxFz1a6fth7y9+2pVbLLutOyrkQt0A== X-Received: by 2002:a05:6870:d2a5:: with SMTP id d37mr55328oae.75.1644583660154; Fri, 11 Feb 2022 04:47:40 -0800 (PST) Received: from ?IPV6:2804:431:c7ca:733:82fc:6b41:692a:b9e0? ([2804:431:c7ca:733:82fc:6b41:692a:b9e0]) by smtp.gmail.com with ESMTPSA id y22sm9014488oto.2.2022.02.11.04.47.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 11 Feb 2022 04:47:39 -0800 (PST) Message-ID: <0dea5e89-25fb-3e17-8142-878482f171dd@linaro.org> Date: Fri, 11 Feb 2022 09:47:37 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0 Subject: Re: [PATCH v2 5/5] Linux: Consolidate auxiliary vector parsing Content-Language: en-US To: Szabolcs Nagy , Florian Weimer Cc: libc-alpha@sourceware.org References: <151c5398adbbe538a275ea5ac77705b0abd0d748.1643886336.git.fweimer@redhat.com> <20220211123110.GB2692478@arm.com> From: Adhemerval Zanella In-Reply-To: <20220211123110.GB2692478@arm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Feb 2022 12:47:42 -0000 On 11/02/2022 09:31, Szabolcs Nagy via Libc-alpha wrote: > this broke aarch64 static binaries: > > The 02/03/2022 12:08, Florian Weimer via Libc-alpha wrote >> void >> _dl_aux_init (ElfW(auxv_t) *av) >> { >> - int seen = 0; >> - uid_t uid = 0; >> - gid_t gid = 0; >> - >> #ifdef NEED_DL_SYSINFO >> /* NB: Avoid RELATIVE relocation in static PIE. */ >> GL(dl_sysinfo) = DL_SYSINFO_DEFAULT; >> #endif >> >> _dl_auxv = av; >> - for (; av->a_type != AT_NULL; ++av) >> - switch (av->a_type) >> - { >> - case AT_PAGESZ: >> - if (av->a_un.a_val != 0) >> - GLRO(dl_pagesize) = av->a_un.a_val; >> - break; >> - case AT_CLKTCK: >> - GLRO(dl_clktck) = av->a_un.a_val; >> - break; >> - case AT_PHDR: >> - GL(dl_phdr) = (const void *) av->a_un.a_val; >> - break; >> - case AT_PHNUM: >> - GL(dl_phnum) = av->a_un.a_val; >> - break; >> - case AT_PLATFORM: >> - GLRO(dl_platform) = (void *) av->a_un.a_val; >> - break; >> - case AT_HWCAP: >> - GLRO(dl_hwcap) = (unsigned long int) av->a_un.a_val; >> - break; >> - case AT_HWCAP2: >> - GLRO(dl_hwcap2) = (unsigned long int) av->a_un.a_val; >> - break; >> - case AT_FPUCW: >> - GLRO(dl_fpu_control) = av->a_un.a_val; >> - break; >> -#ifdef NEED_DL_SYSINFO >> - case AT_SYSINFO: >> - GL(dl_sysinfo) = av->a_un.a_val; >> - break; >> -#endif >> -#ifdef NEED_DL_SYSINFO_DSO >> - case AT_SYSINFO_EHDR: >> - GL(dl_sysinfo_dso) = (void *) av->a_un.a_val; >> - break; >> -#endif >> - case AT_UID: >> - uid ^= av->a_un.a_val; >> - seen |= 1; >> - break; >> - case AT_EUID: >> - uid ^= av->a_un.a_val; >> - seen |= 2; >> - break; >> - case AT_GID: >> - gid ^= av->a_un.a_val; >> - seen |= 4; >> - break; >> - case AT_EGID: >> - gid ^= av->a_un.a_val; >> - seen |= 8; >> - break; >> - case AT_SECURE: >> - seen = -1; >> - __libc_enable_secure = av->a_un.a_val; >> - __libc_enable_secure_decided = 1; >> - break; >> - case AT_RANDOM: >> - _dl_random = (void *) av->a_un.a_val; >> - break; >> - case AT_MINSIGSTKSZ: >> - _dl_minsigstacksize = av->a_un.a_val; >> - break; >> - DL_PLATFORM_AUXV >> - } >> - if (seen == 0xf) >> - { >> - __libc_enable_secure = uid != 0 || gid != 0; >> - __libc_enable_secure_decided = 1; >> - } >> + dl_parse_auxv_t auxv_values = { 0, }; >> + _dl_parse_auxv (av, auxv_values); > > this seems to use memset now on aarch64 before irelative > relocs are resolved in static binaries. > > which causes infinite loops in the iplt (i've also seen > segfaults in the build log). > > i wonder what is a clean fix... > Maybe add inhibit_loop_to_libcall to avoid the memset call.