From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id BA00E3858D35 for ; Tue, 23 May 2023 12:54:51 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BA00E3858D35 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1684846491; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dLz+MgjiqurpVnOx0cTZ9jCCa8XkQJnF+3+35pNhcrk=; b=SFRhQeoPgpFERLwzYmoE1vLA/WhkoRrqzU0YTXL8TYjiUODo5kzzhVXnO5tyUjS8av2opy WFJYe3gN8m3xMcPtShZL/uRx7g7I3Dr4EehxutLQidtG9c/we9yEM3GYjdx3wqwZXzhdcN GBzJJU3GRbAc/M0Ei732GDAVcmbMPMk= Received: from mail-yb1-f197.google.com (mail-yb1-f197.google.com [209.85.219.197]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-264-CevOUdDINtq0ecos9AGpFw-1; Tue, 23 May 2023 08:54:49 -0400 X-MC-Unique: CevOUdDINtq0ecos9AGpFw-1 Received: by mail-yb1-f197.google.com with SMTP id 3f1490d57ef6-ba8696637a7so14567924276.3 for ; Tue, 23 May 2023 05:54:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684846488; x=1687438488; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=dLz+MgjiqurpVnOx0cTZ9jCCa8XkQJnF+3+35pNhcrk=; b=M3GKg+cqwugwX/87AWXKRF0YuNQNrGGa7xIOdlUiOcDCyW9qVDPjbDtP/+FrkZZPLc eNu4cZ9e2og5COnMkOsKpMAlS41CV+7JbR7fcNCwjcGNuDG/HgVlhtsiZzAzJzqEAxM1 6GlnNqnL7hqhj2/JT0mP3MbuQN9CAgt9Ks5FL+RcvfKj2dOJgHY7BREg3N/VlB7UyIWB 9NC+zLsDCy/vC2u7mUiqDhNHFeSNY8sQGjI/IcD07PSn8NDxXTMyT4y0oNU6H2drbPeX WUo0QutjwUIs6CA3rMwQKagdHjL5mRvFBlSqpCl5I9dAGSyXMRfp+H4XDZiGSGCN7RCQ ScrQ== X-Gm-Message-State: AC+VfDyHKe/X7NR3u8GMGSC3CbNtuVAlEODwCZqV4YIou8HPhaZzTRNT UKXo7QTmyo7lu8r9WGOCjnJcgUNIWUpz6ESC/h0H56sqIsd7bB4pvfrH4pLDf2BIy7zRbD7liEA qbfHxv2D96VGqd4qiCxsf X-Received: by 2002:a0d:d5d1:0:b0:54f:bb49:c3a2 with SMTP id x200-20020a0dd5d1000000b0054fbb49c3a2mr15337912ywd.28.1684846488650; Tue, 23 May 2023 05:54:48 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5ZZTvRRSnWYOTHG9DZmd1WfgIyxdeMWd+qeLA4RXiYmFasdc3bTmYUum3bdSoPUTA2PWsfMw== X-Received: by 2002:a0d:d5d1:0:b0:54f:bb49:c3a2 with SMTP id x200-20020a0dd5d1000000b0054fbb49c3a2mr15337894ywd.28.1684846488369; Tue, 23 May 2023 05:54:48 -0700 (PDT) Received: from [192.168.0.241] ([198.48.244.52]) by smtp.gmail.com with ESMTPSA id u132-20020a81608a000000b005611de826bdsm2871243ywb.86.2023.05.23.05.54.47 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 May 2023 05:54:47 -0700 (PDT) Message-ID: <0e345bda-40c5-cb83-dc09-c4653c801ec9@redhat.com> Date: Tue, 23 May 2023 08:54:46 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 0/1] Add linting checks to 'make check' To: Joseph Myers Cc: libc-alpha@sourceware.org, Noah Goldstein , Adhemerval Zanella , Florian Weimer References: <20230519121354.704395-1-carlos@redhat.com> <20c53d6b-b567-346b-4b3f-26c250a91e4@codesourcery.com> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20c53d6b-b567-346b-4b3f-26c250a91e4@codesourcery.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 5/19/23 12:55, Joseph Myers wrote: > On Fri, 19 May 2023, Carlos O'Donell via Libc-alpha wrote: > >> acceptable to lint the Makefile format in 'make check' itself. The check >> needs to run the python interpreter about 200 times, but it's fairly >> fast and on a slow system takes ~3s. My gut feeling is that basic > > If something is significantly slower, I'd suggest parallelizing at the > makefile level (not relevant for a 3s test, but certainly helps for e.g. > the conform/ tests which take quite a lot of time if run in serial but are > extremely parallel). Agreed. Source linting is in that category. -- Cheers, Carlos.