From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Adhemerval Zanella <adhemerval.zanella@linaro.org>,
"libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
Cc: "linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>
Subject: Re: [PATCH v2 3/4] aarch/fpu: use generic builtins based math functions
Date: Tue, 2 Jun 2020 19:14:49 +0000 [thread overview]
Message-ID: <0f807abe-654b-ffbb-c494-aa47656324bc@synopsys.com> (raw)
In-Reply-To: <b885b731-dbae-ebbc-6561-71267138bbdf@linaro.org>
On 6/2/20 10:31 AM, Adhemerval Zanella via Libc-alpha wrote:
>
>
> On 01/06/2020 21:35, Vineet Gupta wrote:
>> introduce sysdep header math-use-builtins.h to replace aarch64
>> impementations with corresponding generic ones
>
> s/impementations/implementations and missing ':'.
Fixed.
>> - newly inroduced generic sqrt{,f}, fma{,f}
>> - existing floor{,f}, nearbyint{,f}, rint{,f}, round{,f}, trunc{,f}
>> - Note that generic copysign was already enabled (via generic
>> math-use-builtins.h) now thru sysdep header
>>
>> This is supposed to be a non functional change
>> Passes build-many for aarch64-linux-gnu
>
> LGTM (just double check if the objects generated by the removed
> implementations did not changed).
I will add the diff output to v3.
next prev parent reply other threads:[~2020-06-02 19:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 0:35 [PATCH v2 0/4] Enable generic math code for more arches Vineet Gupta
2020-06-02 0:35 ` [PATCH v2 1/4] iee754: provide gcc builtins based generic sqrt functions Vineet Gupta
2020-06-02 12:51 ` Stefan Liebler
2020-06-02 16:54 ` Vineet Gupta
2020-06-02 17:17 ` Adhemerval Zanella
2020-06-02 0:35 ` [PATCH v2 2/4] iee754: provide gcc builtins based generic fma functions Vineet Gupta
2020-06-02 12:51 ` Stefan Liebler
2020-06-02 17:13 ` Vineet Gupta
2020-06-02 17:27 ` Adhemerval Zanella
2020-06-03 0:20 ` Vineet Gupta
2020-06-03 6:29 ` Stefan Liebler
2020-06-02 17:28 ` Adhemerval Zanella
2020-06-02 0:35 ` [PATCH v2 3/4] aarch/fpu: use generic builtins based math functions Vineet Gupta
2020-06-02 17:31 ` Adhemerval Zanella
2020-06-02 19:14 ` Vineet Gupta [this message]
2020-06-02 0:35 ` [PATCH v2 4/4] powerpc/fpu: use generic fma functions Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0f807abe-654b-ffbb-c494-aa47656324bc@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=adhemerval.zanella@linaro.org \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).