From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 41486 invoked by alias); 30 Nov 2017 11:37:35 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 40984 invoked by uid 89); 30 Nov 2017 11:37:35 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.2 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD autolearn=no version=3.3.2 spammy=10th, Month, sk:digital, H*M:poczta X-HELO: aev204.rev.netart.pl X-Spam-Score: 0.3 Date: Thu, 30 Nov 2017 11:37:00 -0000 From: Rafal Luzynski Reply-To: Rafal Luzynski To: libc-alpha@sourceware.org Message-ID: <104267343.633254.1512041847567@poczta.nazwa.pl> In-Reply-To: <1189960723.80684.1510832590965@poczta.nazwa.pl> References: <1189960723.80684.1510832590965@poczta.nazwa.pl> Subject: [PING][PATCH v10 0/5][BZ 10871] Month names in alternative grammatical case MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Originating-Client: com.openexchange.ox.gui.dhtml X-SW-Source: 2017-11/txt/msg01040.txt.bz2 16.11.2017 12:43 Rafal Luzynski wrote: > > > This is the 10th version of my patches, this time with a hope that > it may be the final version, hence no more "RFC" tag in the subject. > But, of course, the review is still needed. > > Changes since the previous version (v9): > > * The first patch of the series has been considered complete and > loosely related with the rest therefore has been accepted and > pushed to stable. [1] > * Commit messages corrected. > * ChangeLog changes removed (temporarily, actually moved to other > patches which are not published here). > * Fixed bug in strptime(), thanks Zack Weinberg for finding and > fixing it. > * Order of matching the month names in strptime() is consequent: > basic month name, abbreviated, alternative, abbreviated alternative. > * Some tests for strptime() added. > * Everything rebased to the current (oh, sorry, yesterday's) master. > > This series publishes the patches 1, 3, and 5. These patches are skipped: > > 0002 Regenerate locfile-kw.h + ChangeLog to the previous commit (bug 10871). > 0004 Again regenerate locfile-kw.h + ChangeLog to the previous commit (bug > 10871). > > They contain the changes to the automatically generated files and > should be eventually merged into the patches 1 and 3, respectively, > before pushing to the git repo but should not be reviewed here. > For those who want to examine, they are available in bugzilla [2] > and my github repo. [3] Also note that in order to actually see > any difference you also need the locale data which are not here > but also in bugzilla and github. Unfortunately, my COPR repo [4] > is not updated this time, this means that the packages in the main > Fedora repositories are more recent and will overwrite my packages. > > Again, note that the backward compatibility patches which may be > still around most probably will be rejected. > > Regards, > > Rafal > > > [1] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=f301e53 > [2] https://sourceware.org/bugzilla/show_bug.cgi?id=10871 > [3] https://github.com/rluzynski/glibc > [4] https://copr.fedorainfracloud.org/coprs/rluzynski/genitive/ PING - any feedback about it? Currently my biggest concern is the documentation, changelog and commit messages. I hope that the code itself is correct (but a review is still welcome). Also I'd like to notify that we have discussed this with the Polish translator and the Polish locale [5] [6] will be updated with alternative month names as soon as these patches are pushed. For other locales at least I'd like to try to contact translators. Regards, Rafal [5] https://sourceware.org/bugzilla/show_bug.cgi?id=10871#c119 [6] https://github.com/rluzynski/glibc/blob/master/localedata/locales/pl_PL