From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 83678 invoked by alias); 12 Jul 2019 04:02:31 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 83668 invoked by uid 89); 12 Jul 2019 04:02:31 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:1114 X-HELO: mail-qt1-f194.google.com Return-Path: Subject: Re: [PATCH] test-in-container: Install locales into the test container To: DJ Delorie Cc: fweimer@redhat.com, libc-alpha@sourceware.org References: From: Carlos O'Donell Message-ID: <104acd37-66be-621b-6eb9-e014fac2e81d@redhat.com> Date: Fri, 12 Jul 2019 04:02:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2019-07/txt/msg00253.txt.bz2 On 7/9/19 7:54 PM, DJ Delorie wrote: > "Carlos O'Donell" writes: >> Where do you draw the line? > > Originally I wanted the "make install" to trigger just before the first > test that actually needed it, but I found it very difficult to do that. > Eventually more and more tests will run inside the container, and that > optimization would be useless anyway. > > Perhaps we could at least add $(PARALLELMFLAGS) to the "make install" ? > If it's not already propogated by some other means? Or otherwise > optimize the install process, to limit the overhead during testing? My point is that no matter how good you optimize, eventually there will be enough tests that the time will creep up again. I want Florian to be productive, and I want a build system that supports a straight forward edit/build/test workflow. My question is: How long is too long to wait for the results of testing when you are doing a edit/build/test/debug cycle? Should 'make check' be running enough tests to fill X seconds? -- Cheers, Carlos.