From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 9D4F73943403 for ; Mon, 5 Dec 2022 16:40:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9D4F73943403 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670258408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=y4v3o+dzn2pmmuENgk8If6h9NZJv562pA0tszbyHfio=; b=TWDzg8llglxWFP7u6w6BwalPj+W99jg+iCc2deUp31ak1zwSv94f96Ee5dMg6dG8QvQN8e wlWBK6ujtHRRaJfa7Q7IUg7EGx3IEQHrOBDHAV+s9c8jUaXlrijDWIfm740fmGET0WwDzm SxtV+wWcpgqcpwJvenJk+zq+iEfyk3w= Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-341-jlXyDEOmMJiMI8GiCm6hlA-1; Mon, 05 Dec 2022 11:40:07 -0500 X-MC-Unique: jlXyDEOmMJiMI8GiCm6hlA-1 Received: by mail-io1-f70.google.com with SMTP id f3-20020a5ec703000000b006dfc19c6378so10065920iop.12 for ; Mon, 05 Dec 2022 08:40:06 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=y4v3o+dzn2pmmuENgk8If6h9NZJv562pA0tszbyHfio=; b=Q/s3pLLIqqrlLrnNlkGCAdyWIWzKWJQYDNaJ3a5nmPRWYBIf2uMGAGCi7sQntsV16B OrLkucz+AUiz2swsPnl867gbtNrzQlGz5UyR8SrXphEZ35/itkZGftYYjU9q+aqbnSKd iOESBJsHkfOMjBLkRq2kAJja2b8Aa68aPy/ULq3UOfOgmdT+UJSGh6uxYyzf+gTNaxlj M39LPTKi/cVwKyEpRpSmo/Im6d0FPL04nmh7Fm8Oj82uAqpHFHMS5eHgRavwdXEF5xKm Z3GPOB7uwZNA36yNSZ5zQu2Bdh1k8Xpa4x+Ey0R1XRmmF8nSgR9cxZAOMO+zNlo7bBun rNwA== X-Gm-Message-State: ANoB5pniSJu/Aatjz4PNL5qh/igzbS80iAqXPJiCFSinQTA30n9CFEPG 80jtrSr9UVaMIMplG/AqkInbzY7gAY21/pxdotFxUHHqR1ijLQJzcf8J9a7OyMX1p/Pz8pIVPDp YX2McU/ULreSSG8py8CAV X-Received: by 2002:a92:db42:0:b0:2fa:b6c0:80fd with SMTP id w2-20020a92db42000000b002fab6c080fdmr14193400ilq.164.1670258405559; Mon, 05 Dec 2022 08:40:05 -0800 (PST) X-Google-Smtp-Source: AA0mqf7lUCnAFlLz/OwlBTq7b4c/16vkgsT/LaxKf2Dl+3HslBdQHSo8WQ2hET1OxUlf3Aouzrq4UA== X-Received: by 2002:a92:db42:0:b0:2fa:b6c0:80fd with SMTP id w2-20020a92db42000000b002fab6c080fdmr14193386ilq.164.1670258405242; Mon, 05 Dec 2022 08:40:05 -0800 (PST) Received: from [192.168.0.241] (192-0-145-146.cpe.teksavvy.com. [192.0.145.146]) by smtp.gmail.com with ESMTPSA id a30-20020a027a1e000000b00371caa7ef7csm1053474jac.2.2022.12.05.08.40.04 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Dec 2022 08:40:04 -0800 (PST) Message-ID: <104e3dd6-fbfc-2b27-5b6b-9d3cac27b7d7@redhat.com> Date: Mon, 5 Dec 2022 11:40:04 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.0 Subject: Re: [PATCH 16/30] Linux: Move wordsize-32 Version to default To: Adhemerval Zanella , libc-alpha@sourceware.org References: <20221019221433.1082017-1-adhemerval.zanella@linaro.org> <20221019221433.1082017-17-adhemerval.zanella@linaro.org> From: Carlos O'Donell Organization: Red Hat In-Reply-To: <20221019221433.1082017-17-adhemerval.zanella@linaro.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/19/22 18:14, Adhemerval Zanella via Libc-alpha wrote: > And remove redundant entries on other architectures Version. There are discrepancies between 2.11, 2.15, and 2.18 that need to be explained in the comment or changed. If all 32-bit arches were using 2.11 and the wordsize-32/Versions was never used, then that should be explained in the comment. If microblaze had a default version of 2.18 that pushed up the 2.11 value then that should be explained. Need a v2. > --- > sysdeps/unix/sysv/linux/Versions | 3 +++ > sysdeps/unix/sysv/linux/arm/Versions | 3 --- > sysdeps/unix/sysv/linux/generic/wordsize-32/Versions | 5 ----- > sysdeps/unix/sysv/linux/hppa/Versions | 3 --- > sysdeps/unix/sysv/linux/i386/Versions | 4 ---- > sysdeps/unix/sysv/linux/m68k/Versions | 3 --- > sysdeps/unix/sysv/linux/microblaze/Versions | 5 ----- > sysdeps/unix/sysv/linux/mips/Versions | 3 --- > sysdeps/unix/sysv/linux/powerpc/powerpc32/Versions | 3 --- > sysdeps/unix/sysv/linux/s390/s390-32/Versions | 3 --- > sysdeps/unix/sysv/linux/sh/Versions | 3 --- > sysdeps/unix/sysv/linux/sparc/sparc32/Versions | 3 --- > 12 files changed, 3 insertions(+), 38 deletions(-) > delete mode 100644 sysdeps/unix/sysv/linux/generic/wordsize-32/Versions > delete mode 100644 sysdeps/unix/sysv/linux/microblaze/Versions > > diff --git a/sysdeps/unix/sysv/linux/Versions b/sysdeps/unix/sysv/linux/Versions > index 65d2ceda2c..59c39739c7 100644 > --- a/sysdeps/unix/sysv/linux/Versions > +++ b/sysdeps/unix/sysv/linux/Versions > @@ -157,6 +157,9 @@ libc { > GLIBC_2.10 { > fallocate; > } > + GLIBC_2.11 { > + fallocate64; > + } The generic version says 2.15? sysdeps/unix/sysv/linux/generic/wordsize-32/Versions: libc { GLIBC_2.15 { fallocate64; } } > GLIBC_2.12 { > _sys_errlist; sys_errlist; _sys_nerr; sys_nerr; > > diff --git a/sysdeps/unix/sysv/linux/arm/Versions b/sysdeps/unix/sysv/linux/arm/Versions > index 7e5ba53455..6e7cb6e2e5 100644 > --- a/sysdeps/unix/sysv/linux/arm/Versions > +++ b/sysdeps/unix/sysv/linux/arm/Versions > @@ -4,9 +4,6 @@ libc { > inb; inw; inl; > outb; outw; outl; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_2.24 { > recvmsg; sendmsg; > } > diff --git a/sysdeps/unix/sysv/linux/generic/wordsize-32/Versions b/sysdeps/unix/sysv/linux/generic/wordsize-32/Versions > deleted file mode 100644 > index cdc6022015..0000000000 > --- a/sysdeps/unix/sysv/linux/generic/wordsize-32/Versions > +++ /dev/null > @@ -1,5 +0,0 @@ > -libc { > - GLIBC_2.15 { > - fallocate64; > - } > -} Doesn't match. > diff --git a/sysdeps/unix/sysv/linux/hppa/Versions b/sysdeps/unix/sysv/linux/hppa/Versions > index 357c68a782..78528e5fa2 100644 > --- a/sysdeps/unix/sysv/linux/hppa/Versions > +++ b/sysdeps/unix/sysv/linux/hppa/Versions > @@ -13,9 +13,6 @@ libc { > GLIBC_2.4 { > _sys_errlist; sys_errlist; _sys_nerr; sys_nerr; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_2.12 { > _sys_errlist; sys_errlist; _sys_nerr; sys_nerr; > } > diff --git a/sysdeps/unix/sysv/linux/i386/Versions b/sysdeps/unix/sysv/linux/i386/Versions > index 1335e6551b..f99a4d88d0 100644 > --- a/sysdeps/unix/sysv/linux/i386/Versions > +++ b/sysdeps/unix/sysv/linux/i386/Versions > @@ -37,10 +37,6 @@ libc { > # v* > vm86; > } > - GLIBC_2.11 { > - # f* > - fallocate64; > - } OK. > GLIBC_PRIVATE { > __modify_ldt; __uname; > } > diff --git a/sysdeps/unix/sysv/linux/m68k/Versions b/sysdeps/unix/sysv/linux/m68k/Versions > index d98ae120c1..a77ea60338 100644 > --- a/sysdeps/unix/sysv/linux/m68k/Versions > +++ b/sysdeps/unix/sysv/linux/m68k/Versions > @@ -29,9 +29,6 @@ libc { > # v* > versionsort64; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_2.31 { > msgctl; semctl; shmctl; > } > diff --git a/sysdeps/unix/sysv/linux/microblaze/Versions b/sysdeps/unix/sysv/linux/microblaze/Versions > deleted file mode 100644 > index aa48a3c155..0000000000 > --- a/sysdeps/unix/sysv/linux/microblaze/Versions > +++ /dev/null > @@ -1,5 +0,0 @@ > -libc { > - GLIBC_2.18 { > - fallocate64; > - } > -} Doesn't match. > diff --git a/sysdeps/unix/sysv/linux/mips/Versions b/sysdeps/unix/sysv/linux/mips/Versions > index db6222e9a7..9ea0fa65a4 100644 > --- a/sysdeps/unix/sysv/linux/mips/Versions > +++ b/sysdeps/unix/sysv/linux/mips/Versions > @@ -26,9 +26,6 @@ libc { > pthread_attr_setstack; > pthread_attr_setstacksize; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_PRIVATE { > # nptl/pthread_cond_timedwait.c uses INTERNAL_VSYSCALL(clock_gettime). > __vdso_clock_gettime; > diff --git a/sysdeps/unix/sysv/linux/powerpc/powerpc32/Versions b/sysdeps/unix/sysv/linux/powerpc/powerpc32/Versions > index 918e0231d0..416e8db5ae 100644 > --- a/sysdeps/unix/sysv/linux/powerpc/powerpc32/Versions > +++ b/sysdeps/unix/sysv/linux/powerpc/powerpc32/Versions > @@ -31,9 +31,6 @@ libc { > siglongjmp; > swapcontext; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_2.17 { > __ppc_get_timebase_freq; > } > diff --git a/sysdeps/unix/sysv/linux/s390/s390-32/Versions b/sysdeps/unix/sysv/linux/s390/s390-32/Versions > index bd1a46df88..1b96fc42a3 100644 > --- a/sysdeps/unix/sysv/linux/s390/s390-32/Versions > +++ b/sysdeps/unix/sysv/linux/s390/s390-32/Versions > @@ -44,9 +44,6 @@ libc { > getutmpx; > login; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_2.31 { > msgctl; semctl; shmctl; > } > diff --git a/sysdeps/unix/sysv/linux/sh/Versions b/sysdeps/unix/sysv/linux/sh/Versions > index 9c734ff755..3ad702e165 100644 > --- a/sysdeps/unix/sysv/linux/sh/Versions > +++ b/sysdeps/unix/sysv/linux/sh/Versions > @@ -22,9 +22,6 @@ libc { > # v* > versionsort64; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > GLIBC_2.16 { > fanotify_mark; > } > diff --git a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions > index d928a65346..4529e7fe6f 100644 > --- a/sysdeps/unix/sysv/linux/sparc/sparc32/Versions > +++ b/sysdeps/unix/sysv/linux/sparc/sparc32/Versions > @@ -17,7 +17,4 @@ libc { > # s* > scandir64; > } > - GLIBC_2.11 { > - fallocate64; > - } OK. > } -- Cheers, Carlos.