From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 60C513858CDA for ; Wed, 28 Feb 2024 17:52:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 60C513858CDA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 60C513858CDA Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709142761; cv=none; b=ivZODXNbzCsr98iWfbc9hjol18qwPDAMIV5FVes5L+aYoZQnN+cH5Z3Yql3HBpk2sfRoK1g+vp1Xyx71A9Egv+sFvxhFVHN/xJZ3erETeYLCiMS/XU83hNxRVol3jzE03ac2wVxJ1fIGQqpXpey4riYfmO5j0jJ9OGLkdKmY4r4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1709142761; c=relaxed/simple; bh=S1SMjuQUrwEnY0g4nPoBfNqWp/WKU5Cavvl5+3/l2h8=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=Kw5Y1S8PTaauOc8PhexRw1GAF65cRjRRCh+Bqkf9r9fYB8KQJoDha7a6dsjmOnV//cmH7ij8X5+yst8MEul24WcHRI75xvJJ/2AHkB3pq4t6crMSF5vnskNezbGkZ7FrYzPx/xTOuOMFEBdNvYfn8BpGrtNNhWXUrtupUsFMRgM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709142760; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=e2kaZ9Ox+/mtTl18ifTSDvIhjguAxEVCZDdaEgfx96E=; b=bqD9t9ZYb8hyAlLJyE8iL2/XOlnvDio3vJFkQjY45Ri5hijqhsKh9gha9yAs2dc/v5hR7f UE61ib8oHjb17wKREaHzMf52ZnClRnmLBckJl+K6A8nkfUe7E6sovqPNLz6D9WIpawgsAd tYKGXTi/TyYj2lRq5KmTxCUKzyTQg2Y= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-446-feBBk_knODqMWnphvnzC6w-1; Wed, 28 Feb 2024 12:52:38 -0500 X-MC-Unique: feBBk_knODqMWnphvnzC6w-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-41294023627so8325e9.3 for ; Wed, 28 Feb 2024 09:52:38 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709142756; x=1709747556; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=e2kaZ9Ox+/mtTl18ifTSDvIhjguAxEVCZDdaEgfx96E=; b=rCJXnqBcUNSCtFBZBUVKgQm5+pqEGCw4d5RA7eRhlK5E3BcJa+3LvF/bSJm7QOIzDt eXLT+hLDN10qFmMKPEInXgttd9tfHTHl+lk7FSG9N3XLaTR1R0dKpjDfQhGOHRTpxMsQ WE4YdJpE9bgafGivG4DpTJOwAHRsLntt+GFK6EHNcueX0pzPk8phFnOiD7NTzHhdo8Zy wpTthzbvpc/z/5ayUfu2y/F9RyMG6WehdQTbNIPUJNQYzehSdMKW1Zm/Mg7ipW425MQi 3Vw211vewIySIoySl6q55s7XkDV2yiDS2f2hUTWeSIQk2lc5XyUTzIRAmflbgfW01kyv Lo6w== X-Gm-Message-State: AOJu0Yxo0+r4W34/aK66VCvO4d8fG4V0BTAWM9Rrg6P38BpRK+ABUalJ Jp5CQLA4VtpqD+doYa9MigyCSsTi/+c1zdQXN57FmQSJjTKtIWC3bJlftYSQMvBNnNIwJ8ApSFO pfXV8CWqxvWnC+S3Ux62pkJR25F4xyF0o8OD5+b3g0VsbCsdle8m8cZyamBp6H3KZKg== X-Received: by 2002:a05:600c:4e4f:b0:412:b652:27bf with SMTP id e15-20020a05600c4e4f00b00412b65227bfmr170744wmq.16.1709142756682; Wed, 28 Feb 2024 09:52:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEcndqmv6jIYOS5k3sxZcJOnPSuhHjqygm0GjwyQ/1hEEZ24JiRv6x9CJ4mteUF6fhYoPFt6A== X-Received: by 2002:a05:600c:4e4f:b0:412:b652:27bf with SMTP id e15-20020a05600c4e4f00b00412b65227bfmr170733wmq.16.1709142756357; Wed, 28 Feb 2024 09:52:36 -0800 (PST) Received: from digraph.polyomino.org.uk (digraph.polyomino.org.uk. [2001:8b0:bf73:93f7::51bb:e332]) by smtp.gmail.com with ESMTPSA id i4-20020a05600c354400b004101f27737asm2851624wmq.29.2024.02.28.09.52.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Feb 2024 09:52:36 -0800 (PST) Received: from jsm28 (helo=localhost) by digraph.polyomino.org.uk with local-esmtp (Exim 4.95) (envelope-from ) id 1rfO6A-000Bf0-1J; Wed, 28 Feb 2024 17:52:06 +0000 Date: Wed, 28 Feb 2024 17:52:06 +0000 (UTC) From: Joseph Myers To: Florian Weimer cc: libc-alpha@sourceware.org Subject: Re: [PATCH v3 11/32] elf: Merge the three implementations of _dl_dst_substitute In-Reply-To: Message-ID: <1087df9e-958d-9397-8d5-908db19c6150@redhat.com> References: MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 7 Dec 2023, Florian Weimer wrote: > Use one implementation to perform the copying and the counting. > > The IS_RTLD check for l_origin processing is eliminated because > $ORIGIN cannot used with the ld.so link map (and not with the > vDSO link map either) because there is no user code associated > with it that might call dlopen with an $ORIGIN path. OK, together with the removal of dl-dst.h and of its inclusion in elf/dl-origin.c if that's what's intended. -- Joseph S. Myers josmyers@redhat.com