From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2b.google.com (mail-oa1-x2b.google.com [IPv6:2001:4860:4864:20::2b]) by sourceware.org (Postfix) with ESMTPS id 08A483858D32 for ; Thu, 25 May 2023 17:36:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 08A483858D32 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2b.google.com with SMTP id 586e51a60fabf-19a13476ffeso5787fac.0 for ; Thu, 25 May 2023 10:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1685036191; x=1687628191; h=content-transfer-encoding:in-reply-to:organization:references:to :from:content-language:subject:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=Q4GfG1WsoFTbhPqOzn6bjK0Op8xTb4z1elOeupcNXHA=; b=qKnrjEJlI11QsUzjT4rrUfb+zv/P+NswPmpI+4H+qIpYqB2dW7E/GLXDQNxhWZVrrA BIzmqTjfaLwIw36u306nGhLhxrSRgfoY+UYymb8qlYMYO3GBMt3ZqGWFiwcC2NpGrSBF 8QDtyiySfcqT6+ePZbOHbZJcxhMLHJuXW1BERryNR4c8PFBxiHa+N/Y1YzEbPTXyDVUD lXOqbtRSYhGr2wp/0plKyFGsfrcoaQA+F9+IzLYsGBxdFsjHSc3vwkRZD4C4mJnZtN/h yxLsFuaseoPkdJ0PJfdjQaXksmEeqUAMhfFR1lLSUqqD78sj2x8E5mFxnlEnK3TsxZYp EAgQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685036191; x=1687628191; h=content-transfer-encoding:in-reply-to:organization:references:to :from:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q4GfG1WsoFTbhPqOzn6bjK0Op8xTb4z1elOeupcNXHA=; b=jKi4C9fGV7G/R57i5X/IIz1vO7yRKn/nDlYeqQ8ahtrTqVDfn/7wkUbeQ7cL1pQ527 bNr4S+CRoYD9srBaYAyXhaw6soEP38GvgTHOUIDhaAaRvVdBsCelEqi3QqnfLV54DD3V 6/7bf8Hb0//y79KWPHBD3SGiSibE/PPWdNhvF4nGNc3wiUy3OIfsK4zbTzYUlH/KeocU 3N8UzYeVJraPBHoNPZ4Nh6sOJooXROfE+TJxRE1NEjHnclUKXegaC09se8tKxZHt4+9t JZHe6z3wFixPeAXdUsY/N/8hiek6CvUOFhir2R2nLA0d5mPZNE6rbos3lAOytJ4OoYGs pPHg== X-Gm-Message-State: AC+VfDwKLuXo91BuYKD9btgFXDmadSMwk0vJD7TNdWHdp3FuqkisTWc7 zjh26aBcFsRH3+FYwd8lQsQCMPURq0VU8nA31TEM7g== X-Google-Smtp-Source: ACHHUZ5N8aGPBndg+r1oJs6DiFLHdEbDZqYSjfT8pIfBW2PKfWfn8lTyniX9+oC+vWKZmdxSITu58w== X-Received: by 2002:a05:6870:b7ae:b0:19d:d608:3a48 with SMTP id ed46-20020a056870b7ae00b0019dd6083a48mr2590706oab.24.1685036190932; Thu, 25 May 2023 10:36:30 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c1:4dd5:80c6:51f7:4cf7:20d3? ([2804:1b3:a7c1:4dd5:80c6:51f7:4cf7:20d3]) by smtp.gmail.com with ESMTPSA id e5-20020a056870450500b001723f29f6e2sm856911oao.37.2023.05.25.10.36.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 May 2023 10:36:29 -0700 (PDT) Message-ID: <10d11f7f-a531-1d35-338e-465919ff4f91@linaro.org> Date: Thu, 25 May 2023 14:36:27 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.1 Subject: Re: [PATCH 2/5] s390x: Add the clone3 wrapper Content-Language: en-US From: Adhemerval Zanella Netto To: libc-alpha@sourceware.org References: <20230203171237.1220878-1-adhemerval.zanella@linaro.org> <20230203171237.1220878-3-adhemerval.zanella@linaro.org> Organization: Linaro In-Reply-To: <20230203171237.1220878-3-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Ping. On 03/02/23 14:12, Adhemerval Zanella wrote: > It follows the internal signature: > > extern int clone3 (struct clone_args *__cl_args, size_t __size, > int (*__func) (void *__arg), void *__arg); > > Checked on s390x-linux-gnu. > --- > sysdeps/unix/sysv/linux/s390/s390-64/clone3.S | 81 +++++++++++++++++++ > sysdeps/unix/sysv/linux/s390/sysdep.h | 1 + > 2 files changed, 82 insertions(+) > create mode 100644 sysdeps/unix/sysv/linux/s390/s390-64/clone3.S > > diff --git a/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S > new file mode 100644 > index 0000000000..417fdcb785 > --- /dev/null > +++ b/sysdeps/unix/sysv/linux/s390/s390-64/clone3.S > @@ -0,0 +1,81 @@ > +/* The clone3 syscall wrapper. Linux/s390x version. > + Copyright (C) 2023 Free Software Foundation, Inc. > + > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > +#define _ERRNO_H 1 > +#include > + > +/* The userland implementation is: > + int clone3 (struct clone_args *cl_args, size_t size, > + int (*func)(void *arg), void *arg); > + > + the kernel entry is: > + int clone3 (struct clone_args *cl_args, size_t size); > + > + The parameters are passed in registers from userland: > + r2: cl_args > + r3: size > + r4: func > + r5: arg */ > + > + .text > +ENTRY(__clone3) > + stg %r6, 48(%r15) > + > + /* Sanity check args. */ > + ltgr %r2, %r2 > + je error > + ltgr %r6, %r4 > + je error > + > + /* Do the system call, the kernel expects: > + r1: system call number > + r2: cl_args > + r3: size */ > + lghi %r1, SYS_ify(clone3) > + svc 0 > + ltgr %r2,%r2 /* check return code */ > + jz thread_start > + lg %r6, 48(%r15) > + jgm SYSCALL_ERROR_LABEL > + br %r14 > +error: > + lghi %r2,-EINVAL > + jg SYSCALL_ERROR_LABEL > +PSEUDO_END (__clone3) > + > + .align 4 > + .type thread_start, %function > +thread_start: > + cfi_startproc > + /* Mark r14 as undefined in order to stop unwinding here. */ > + cfi_undefined (r14) > + > + /* func is in gpr 6, arg in gpr 5. */ > + lgr %r2, %r5 > + aghi %r15, -160 > + xc 0(8,%r15),0(%r15) > + basr %r14, %r6 > + > + DO_CALL (exit, 1) > + cfi_endproc > + .size thread_start, .-thread_start > + > +libc_hidden_def (__clone3) > +weak_alias (__clone3, clone3) > diff --git a/sysdeps/unix/sysv/linux/s390/sysdep.h b/sysdeps/unix/sysv/linux/s390/sysdep.h > index 3bde8ba19c..b099fea9c6 100644 > --- a/sysdeps/unix/sysv/linux/s390/sysdep.h > +++ b/sysdeps/unix/sysv/linux/s390/sysdep.h > @@ -72,6 +72,7 @@ > #ifdef __s390x__ > #define HAVE_CLOCK_GETRES64_VSYSCALL "__kernel_clock_getres" > #define HAVE_CLOCK_GETTIME64_VSYSCALL "__kernel_clock_gettime" > +#define HAVE_CLONE3_WRAPPER 1 > #else > #define HAVE_CLOCK_GETRES_VSYSCALL "__kernel_clock_getres" > #define HAVE_CLOCK_GETTIME_VSYSCALL "__kernel_clock_gettime"