From: Vineet Gupta <Vineet.Gupta1@synopsys.com>
To: Joseph Myers <joseph@codesourcery.com>,
Florian Weimer <fw@deneb.enyo.de>
Cc: Stepan Golosunov <stepan@golosunov.pp.ru>,
Alistair Francis <alistair.francis@wdc.com>,
"linux-snps-arc@lists.infradead.org"
<linux-snps-arc@lists.infradead.org>,
Vineet Gupta via Libc-alpha <libc-alpha@sourceware.org>
Subject: Re: [PATCH] provide y2038 safe socket constants
Date: Tue, 31 Mar 2020 21:00:22 +0000 [thread overview]
Message-ID: <10f0a47d-189d-14f2-f665-5b5532be629b@synopsys.com> (raw)
In-Reply-To: <alpine.DEB.2.21.2003312038320.30236@digraph.polyomino.org.uk>
On 3/31/20 1:45 PM, Joseph Myers wrote:
> I'm concerned the present patch is wrong for x32, however; that has
> __TIMESIZE == 64 && __WORDSIZE == 32 but should use the old values; the
> patch should be using __SYSCALL_WORDSIZE when available in place of
> __WORDSIZE.
Something like below ?
-#if __TIMESIZE == 64 && __WORDSIZE == 32
+#if TIMESIZE == 64 && (__WORDSIZE == 32 \
&& (!defined __SYSCALL_WORDSIZE || __SYSCALL_WORDSIZE == 32))
Also is it ok to littler the code (multiple times, this patch and else where) with
this or should we define a new __32BIT_ARCH_NOT_X32 or some such ?
next prev parent reply other threads:[~2020-03-31 21:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 4:16 Vineet Gupta
2020-03-31 19:24 ` Vineet Gupta
2020-03-31 19:34 ` Florian Weimer
[not found] ` <dc454c9b-d947-5fcc-6a27-1e6da8faecb5@synopsys.com>
[not found] ` <874ku4qnvs.fsf@mid.deneb.enyo.de>
2020-03-31 20:28 ` Vineet Gupta
2020-03-31 20:45 ` Joseph Myers
2020-03-31 21:00 ` Vineet Gupta [this message]
2020-03-31 21:22 ` Joseph Myers
2020-03-31 21:32 ` [PATCH v2] provide y2038 safe socket constants for default/asm-generic ABI Vineet Gupta
2020-04-06 18:55 ` Vineet Gupta
2020-04-13 21:11 ` Vineet Gupta
2020-04-17 23:20 ` Joseph Myers
2020-04-18 0:03 ` Vineet Gupta
2020-04-19 20:35 ` Vineet Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=10f0a47d-189d-14f2-f665-5b5532be629b@synopsys.com \
--to=vineet.gupta1@synopsys.com \
--cc=alistair.francis@wdc.com \
--cc=fw@deneb.enyo.de \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=linux-snps-arc@lists.infradead.org \
--cc=stepan@golosunov.pp.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).