From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/3] nptl: Move pthread_cancel into libc
Date: Tue, 11 May 2021 15:36:29 -0300 [thread overview]
Message-ID: <11056e20-1119-e389-2269-51eea6b4b968@linaro.org> (raw)
In-Reply-To: <871radxhfa.fsf@oldenburg.str.redhat.com>
On 11/05/2021 15:18, Florian Weimer wrote:
> * Adhemerval Zanella:
>
>> On 11/05/2021 14:37, Florian Weimer wrote:
>>> * Adhemerval Zanella:
>>>
>>>>> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h
>>>>> index 1692788528..5b844f331a 100644
>>>>> --- a/nptl/pthreadP.h
>>>>> +++ b/nptl/pthreadP.h
>>>>> @@ -521,7 +521,6 @@ extern pthread_t __pthread_self (void);
>>>>> extern int __pthread_equal (pthread_t thread1, pthread_t thread2);
>>>>> extern int __pthread_detach (pthread_t th);
>>>>> libc_hidden_proto (__pthread_detach)
>>>>> -extern int __pthread_cancel (pthread_t th);
>>>>> extern int __pthread_kill (pthread_t threadid, int signo);
>>>>> extern void __pthread_exit (void *value) __attribute__ ((__noreturn__));
>>>>> libc_hidden_proto (__pthread_exit)
>>>>
>>>> I am kinda puzzled how the libc_hidden_proto work without the __pthread_cancel
>>>> prototype.
>>>
>>> Sorry, I don't understand the question? Did I leave libc_hidden_def
>>> somewhere by mistake?
>>
>> No, it is from where libc_hidden_proto gets __pthread_cancel
>> definition to use on its internal __typeof.
>
> There's no libc_hidden_proto (__pthread_cancel) before or after this
> patch. Sorry for being terse, I really don't get what you are after.
Nevermind, it was a confusion from my part. The patch look good.
prev parent reply other threads:[~2021-05-11 18:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-11 10:56 [PATCH 0/3] nptl: Move remaining cancellation functionality " Florian Weimer
2021-05-11 10:56 ` [PATCH 1/3] nptl: Move __pthread_register_cancel, __pthread_unregister_cancel to libc Florian Weimer
2021-05-11 17:27 ` Adhemerval Zanella
2021-05-11 10:56 ` [PATCH 2/3] nptl: Move __pthread_register_cancel_defer, __pthread_unregister_cancel_restore " Florian Weimer
2021-05-11 17:29 ` Adhemerval Zanella
2021-05-11 10:56 ` [PATCH 3/3] nptl: Move pthread_cancel into libc Florian Weimer
2021-05-11 17:32 ` Adhemerval Zanella
2021-05-11 17:37 ` Florian Weimer
2021-05-11 18:13 ` Adhemerval Zanella
2021-05-11 18:18 ` Florian Weimer
2021-05-11 18:36 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11056e20-1119-e389-2269-51eea6b4b968@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).