From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt1-x82e.google.com (mail-qt1-x82e.google.com [IPv6:2607:f8b0:4864:20::82e]) by sourceware.org (Postfix) with ESMTPS id 1D915388E808 for ; Tue, 11 May 2021 18:36:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 1D915388E808 Received: by mail-qt1-x82e.google.com with SMTP id f8so11179253qth.6 for ; Tue, 11 May 2021 11:36:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=7NQYgtI+cqFY0cPh2uXtc5bho8g1XkVPmNV8gMaRH+U=; b=MDww3qTZpXCTXMNQ9ZYVbgVcAs0QT0ZnjD4a5RZIDZky7CHm0jZXmxBsY9TmFylXro gozag4HOKsrukrgWUXV2K6+jifwBYk99nberxfRDuNp6KRwyR6zJlaE1Vq24azzANSy7 Nz66HioR3GSKTEBFhLoTs4Q3fO26pYqmBCFBxhumkCss19QY6viqupfGLAm+VbvCkp5f 0SPGSVN+wstS3baE1Mxeqz+1z64Uj9lh7n5j6cA36lXn1tAubQiibdXwW42oomdtYHak ZRPm2BfSbvh6WKyep/tHKEtgAVX/hifpYkI9QB+DNw5J/kT8s7xZja+VP6PCYalQ42JI RlPQ== X-Gm-Message-State: AOAM532xj7vVv5G7Y9x6P08Y03drnJDQvEpfMy8vikCIwXZZNKs9Doit BHZrkhTn8DovG+MFX23h7jRiRN0yuD3Giw== X-Google-Smtp-Source: ABdhPJw1iGSRJrYBcT4N6lKaQimtPVHIc2EH2CRpIEU0ss9+7UstweTJ8v2urVdrjWXWSGHehpXdRQ== X-Received: by 2002:ac8:1110:: with SMTP id c16mr29062824qtj.117.1620758192417; Tue, 11 May 2021 11:36:32 -0700 (PDT) Received: from [192.168.1.4] ([177.194.37.86]) by smtp.gmail.com with ESMTPSA id o10sm13057550qki.72.2021.05.11.11.36.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 May 2021 11:36:31 -0700 (PDT) Subject: Re: [PATCH 3/3] nptl: Move pthread_cancel into libc To: Florian Weimer Cc: libc-alpha@sourceware.org References: <1c9e0befaa92592c8f6488c1235ebbfe39d0a61c.1620730539.git.fweimer@redhat.com> <76ab35d6-8a65-921a-59ab-be4e0418afba@linaro.org> <87k0o5xjcp.fsf@oldenburg.str.redhat.com> <341d783d-5432-8cfa-b071-6561902b817d@linaro.org> <871radxhfa.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <11056e20-1119-e389-2269-51eea6b4b968@linaro.org> Date: Tue, 11 May 2021 15:36:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <871radxhfa.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-12.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 May 2021 18:36:34 -0000 On 11/05/2021 15:18, Florian Weimer wrote: > * Adhemerval Zanella: > >> On 11/05/2021 14:37, Florian Weimer wrote: >>> * Adhemerval Zanella: >>> >>>>> diff --git a/nptl/pthreadP.h b/nptl/pthreadP.h >>>>> index 1692788528..5b844f331a 100644 >>>>> --- a/nptl/pthreadP.h >>>>> +++ b/nptl/pthreadP.h >>>>> @@ -521,7 +521,6 @@ extern pthread_t __pthread_self (void); >>>>> extern int __pthread_equal (pthread_t thread1, pthread_t thread2); >>>>> extern int __pthread_detach (pthread_t th); >>>>> libc_hidden_proto (__pthread_detach) >>>>> -extern int __pthread_cancel (pthread_t th); >>>>> extern int __pthread_kill (pthread_t threadid, int signo); >>>>> extern void __pthread_exit (void *value) __attribute__ ((__noreturn__)); >>>>> libc_hidden_proto (__pthread_exit) >>>> >>>> I am kinda puzzled how the libc_hidden_proto work without the __pthread_cancel >>>> prototype. >>> >>> Sorry, I don't understand the question? Did I leave libc_hidden_def >>> somewhere by mistake? >> >> No, it is from where libc_hidden_proto gets __pthread_cancel >> definition to use on its internal __typeof. > > There's no libc_hidden_proto (__pthread_cancel) before or after this > patch. Sorry for being terse, I really don't get what you are after. Nevermind, it was a confusion from my part. The patch look good.