From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <libc-alpha-return-99256-listarch-libc-alpha=sources.redhat.com@sourceware.org>
Received: (qmail 44141 invoked by alias); 15 Jan 2019 10:01:01 -0000
Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <libc-alpha.sourceware.org>
List-Subscribe: <mailto:libc-alpha-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/libc-alpha/>
List-Post: <mailto:libc-alpha@sourceware.org>
List-Help: <mailto:libc-alpha-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: libc-alpha-owner@sourceware.org
Received: (qmail 44124 invoked by uid 89); 15 Jan 2019 10:01:00 -0000
Authentication-Results: sourceware.org; auth=none
X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=matthew, Matthew, malcomson, Malcomson
X-HELO: EUR01-DB5-obe.outbound.protection.outlook.com
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com;
 s=selector1-arm-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=Jz5DXcKhG7jIvnxfTMbmyOgFeA5pn0NAttlHGUMgRsc=;
 b=A1sZ7Cn7cTuNcq4tFsFWLqp6enHPXz1Eet5PFhJ4TIQ7RjadqM2dgLjMrImHNoZx70Fd01dvLvVcc/z9uVKGQA8BmSTu6LBtUYa+do4Pr9SbRMLH3x+cI/3rJyRP0n6nr76HEugbTOHVkmRazzb6xmWlvAEz69tE9v+S/JSUCBE=
From: Matthew Malcomson <Matthew.Malcomson@arm.com>
To: "libc-alpha@sourceware.org" <libc-alpha@sourceware.org>
CC: nd <nd@arm.com>
Subject: Re: [Patch] [Makefile] Exit if provided an incorrect argument
Date: Tue, 15 Jan 2019 10:01:00 -0000
Message-ID: <112a37a4-90fe-c014-5525-71cb042275d2@arm.com>
References:
 <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com>
In-Reply-To:
 <VI1PR0801MB20145F5DF9B9E836FB02F5BCE0A10@VI1PR0801MB2014.eurprd08.prod.outlook.com>
authentication-results: spf=none (sender IP is )
 smtp.mailfrom=Matthew.Malcomson@arm.com; 
received-spf: None (protection.outlook.com: arm.com does not designate
 permitted sender hosts)
Content-Type: text/plain; charset="Windows-1252"
Content-ID: <D6D920E4F44243498E5FB279B939729E@eurprd08.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-SW-Source: 2019-01/txt/msg00326.txt.bz2

ping


On 14/12/18 14:26, Matthew Malcomson wrote:
> At the moment the ./testrun.sh file generated for testing a new glibc
> doesn't handle incorrect arguments well.
> It prints the usage of the script in an infinite loop.
>
> This patch stops the infinite loop by exiting the program.
>
> Tested by manually running the script after building.
> I don't have commit rights, so if OK could someone commit this for me.
> OK for master?
>
> ChangeLog:
>
> 2018-11-29  Matthew Malcomson  <matthew.malcomson@arm.com>
>
> 	* Makefile (testrun.sh): Exit if provided incorrect arg.
>
>
> diff --git a/Makefile b/Makefile
> index b4703e48fec93075cd5e3ddd83469705d2fee8f8..1e1866be3da1ba4520911eb27=
016544de419161b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -148,6 +148,7 @@ while test $$# -gt 0 ; do
>         ;;
>       --*)
>         usage
> +      exit 1
>         ;;
>       *)
>         break
>