From: kemi <kemi.wang@intel.com>
To: Carlos O'Donell <carlos@redhat.com>,
Adhemerval Zanella <adhemerval.zanella@linaro.org>,
Florian Weimer <fweimer@redhat.com>, Rical Jason <rj@2c3t.io>,
Glibc alpha <libc-alpha@sourceware.org>
Cc: Dave Hansen <dave.hansen@linux.intel.com>,
Tim Chen <tim.c.chen@intel.com>,
Andi Kleen <andi.kleen@intel.com>,
Ying Huang <ying.huang@intel.com>, Aaron Lu <aaron.lu@intel.com>,
Lu Aubrey <aubrey.li@intel.com>
Subject: Re: [RFC 0/4] Add a new mutex type PTHREAD_MUTEX_QUEUESPINNER_NP
Date: Fri, 06 Jul 2018 07:46:00 -0000 [thread overview]
Message-ID: <1180377b-e5f3-c7b0-ae40-07cb53116102@intel.com> (raw)
In-Reply-To: <4b86721b-56f0-2968-305e-176198cf2cf8@intel.com>
On 2018å¹´07æ06æ¥ 09:32, kemi wrote:
>
>
> On 2018å¹´07æ06æ¥ 04:12, Carlos O'Donell wrote:
>> On 07/02/2018 04:11 AM, Kemi Wang wrote:
>>> The pthread adaptive mutex is designed based-on the truth that the lock
>>> probably would be released after a few of CPU cycles in most cases.
>>> Especially for the case: the applications code is well-behaved with a short
>>> critical section that is highly contended. Thus, spinning on the lock for
>>> a while instead of calling into the kernel to block immediately can help
>>> to improve the system performance.
>>
>> This patch set is going to take a while to review.
>>
>
BTW, I can separate 1/4 patch into several sub-patches if you think it would
be easier for review:)
> Yes. Thanks for taking your time to review!
>
>> We are currently freezing the ABI/API for glibc 2.28 release on August 1st.
>>
>
> I know. This patch series introduces a new mutex type and would not break the
> existed ABI/API.
>
>
>> Are you OK if we delay the inclusion of this feature to 2.29 once master
>> reopens?
>
> I hope we can pick this feature before 2.28 release if you are comfortable.
>
> The new mutex type would benefit some guys who have severe lock contention in
> their applications (Actually, some of our customers have complained to us). And
> we can keep improving this feature after 2.28 release later.
>
>>
next prev parent reply other threads:[~2018-07-06 7:46 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-02 8:16 Kemi Wang
2018-07-02 8:16 ` [PATCH 4/4] Manual: Add manual for pthread mutex Kemi Wang
2018-07-02 8:17 ` [PATCH 2/4] Mutex: add unit tests for new type Kemi Wang
2018-07-02 8:17 ` [PATCH 3/4] BENCHMARK: add a benchmark for testing new type of mutex Kemi Wang
2018-07-02 8:17 ` [PATCH 1/4] Mutex: Queue spinners to reduce cache line bouncing and ensure fairness Kemi Wang
2018-07-05 20:12 ` [RFC 0/4] Add a new mutex type PTHREAD_MUTEX_QUEUESPINNER_NP Carlos O'Donell
2018-07-06 1:35 ` kemi
2018-07-06 7:46 ` kemi [this message]
2018-07-06 12:42 ` Carlos O'Donell
2018-07-06 15:56 ` Wang, Kemi
2018-07-06 16:17 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1180377b-e5f3-c7b0-ae40-07cb53116102@intel.com \
--to=kemi.wang@intel.com \
--cc=aaron.lu@intel.com \
--cc=adhemerval.zanella@linaro.org \
--cc=andi.kleen@intel.com \
--cc=aubrey.li@intel.com \
--cc=carlos@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
--cc=rj@2c3t.io \
--cc=tim.c.chen@intel.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).