From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oa1-x2a.google.com (mail-oa1-x2a.google.com [IPv6:2001:4860:4864:20::2a]) by sourceware.org (Postfix) with ESMTPS id BDEF53858D28 for ; Tue, 11 Apr 2023 17:30:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BDEF53858D28 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-oa1-x2a.google.com with SMTP id 586e51a60fabf-1842e278605so10644289fac.6 for ; Tue, 11 Apr 2023 10:30:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1681234202; x=1683826202; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=utLsHo99rnpHy7C3WobaCwjHW7qJbNcJqzFG2gBGMmU=; b=Vio+eYItkpdWz8ulKZrvlmv+hUIPmKk21YoLB9DLGb+vxFP1HLxh+1HbWmYl93JzT1 53ktimIm6NLPhwdsxgLnyvtYTwsXrKP5OoYQwo0Q+wlkiCCGMixF3H4X2T46rLgSCSRu 6sq3Trr7xCHFOnIYBIf87031eRWpEyyWtqt87QBNAvlG1WwVTLJZaANa8T6o85D4fiLV Z9HI8R/P5NDTtCVKNMh+2SfkNfz+pHNnVTfHZAPIkH7x57x65IPEK+zpdWluKtkq4rI+ V0uj5Geue6h7ZLPwujUuqfTX5hKeMNmh2EzhV6YTCZM560qNfXxY6Djk0xRpufIPA+cI Smew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681234202; x=1683826202; h=content-transfer-encoding:in-reply-to:organization:from:references :to:content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=utLsHo99rnpHy7C3WobaCwjHW7qJbNcJqzFG2gBGMmU=; b=MTbSTr38rqI18UKqkOXFB28MJIcJec9apXU3pf44mrtVPN/srELawfZC2hU+biCIeT 5YOFxEK/wN4pheqFDInwebWduasPSaOs3aGa62J+8zhg6mg9o/d6eLt2qCTQ4V0t+D8K 8Mr7K/Cwj4InuKpVaQSfxhDuijwkO7CEVtRonlhIAXoQ/miFzb3FUvbz1G+Wlrdg7Ic5 acU7FnUI69Lb+8GZQ3YdldMD5XwgIpDdlDBR8AQrHvzvs2VuDrypDuXN2LT+DW9odJ1c W8Kjn6THRObKUYDBtFKQgJ0M+IZinnzlmma02s7/e5RL1HaLdA2SVFiyAMauQPu4WX78 GSrA== X-Gm-Message-State: AAQBX9fMNsyNeh3PNsKGUEeaB/MdKLo5lg+Cnsqz2d0imWXLN+ML/C63 rG85xgGbgXMMUjyAUwNVxyaqJ518pS/Se+cTWA3sIA== X-Google-Smtp-Source: AKy350ZU7R4vMhfA/fLgfk7r+wGdxEM/2w2gn5wo4jrBSMW2DLGMwEYw1FEb0/fox0SrEyusRNxpSA== X-Received: by 2002:a05:6870:64a7:b0:17f:7548:6781 with SMTP id cz39-20020a05687064a700b0017f75486781mr8027506oab.40.1681234202512; Tue, 11 Apr 2023 10:30:02 -0700 (PDT) Received: from ?IPV6:2804:1b3:a7c2:55a1:7428:425e:4ee7:30b6? ([2804:1b3:a7c2:55a1:7428:425e:4ee7:30b6]) by smtp.gmail.com with ESMTPSA id e12-20020a9d730c000000b006a3ae1c5a30sm5579917otk.9.2023.04.11.10.30.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Apr 2023 10:30:01 -0700 (PDT) Message-ID: <118992ac-267b-81a1-f6bf-800004ebc94b@linaro.org> Date: Tue, 11 Apr 2023 14:29:59 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH v4 3/4] string: Add tests for strndup (BZ #30266) Content-Language: en-US To: libc-alpha@sourceware.org, Joe Simmons-Talbott References: <20230329150500.2886135-1-josimmon@redhat.com> <20230410155934.3503627-1-josimmon@redhat.com> <20230410155934.3503627-4-josimmon@redhat.com> From: Adhemerval Zanella Netto Organization: Linaro In-Reply-To: <20230410155934.3503627-4-josimmon@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-13.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,KAM_SHORT,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 10/04/23 12:59, Joe Simmons-Talbott via Libc-alpha wrote: > Copy strncpy tests for strndup. Covers some basic testcases with random > strings. Remove tests that set the destination's bytes and checked the > resulting buffer's bytes. Remove wide character test support since > wcsndup() doesn't exist. Some minor issues below. > --- > string/Makefile | 1 + > string/test-strndup.c | 222 ++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 223 insertions(+) > create mode 100644 string/test-strndup.c > > diff --git a/string/Makefile b/string/Makefile > index 472e318aea..2eef6f1dfc 100644 > --- a/string/Makefile > +++ b/string/Makefile > @@ -163,6 +163,7 @@ tests := \ > test-strncat \ > test-strncmp \ > test-strncpy \ > + test-strndup \ > test-strnlen \ > test-strpbrk \ > test-strrchr \ Ok. > diff --git a/string/test-strndup.c b/string/test-strndup.c > new file mode 100644 > index 0000000000..b5665a3eec > --- /dev/null > +++ b/string/test-strndup.c > @@ -0,0 +1,222 @@ > +/* Test strndup functions. > + Copyright (C) 2023 Free Software Foundation, Inc. > + This file is part of the GNU C Library. > + > + The GNU C Library is free software; you can redistribute it and/or > + modify it under the terms of the GNU Lesser General Public > + License as published by the Free Software Foundation; either > + version 2.1 of the License, or (at your option) any later version. > + > + The GNU C Library is distributed in the hope that it will be useful, > + but WITHOUT ANY WARRANTY; without even the implied warranty of > + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU > + Lesser General Public License for more details. > + > + You should have received a copy of the GNU Lesser General Public > + License along with the GNU C Library; if not, see > + . */ > + > +#include > + > +#define CHAR char > +#define UCHAR unsigned char > +#define BIG_CHAR CHAR_MAX > +#define SMALL_CHAR 127 > +#define MEMSET memset > + > + > +#ifndef STRNDUP_RESULT > +# define STRNDUP_RESULT(dst, len, n) dst > +# define TEST_MAIN > +# define TEST_NAME "strndup" > +# include "test-string.h" > + > +#endif /* !STRNDUP_RESULT */ Just remove these definitions and use the definitions directly. > + > +static void > +do_one_test (const CHAR *src, size_t len, size_t n) > +{ > + CHAR *dst = strndup(src, n); > + size_t s = (len > n ? n: len) * sizeof (CHAR); > + > + TEST_COMPARE_BLOB(dst, s, src, s); > +} > + > +static void > +do_test (size_t align1, size_t align2, size_t len, size_t n, int max_char) > +{ > + size_t i; > + CHAR *s1; > + > +/* For wcsndup: align1 and align2 here mean alignment not in bytes, > + but in wchar_ts, in bytes it will equal to align * (sizeof (wchar_t)). */ This comment does not really apply (wcsndup does not exit). > + align1 &= 7; > + if ((align1 + len) * sizeof (CHAR) >= page_size) > + return; > + > + align2 &= 7; > + if ((align2 + len) * sizeof (CHAR) >= page_size) > + return; > + > + s1 = (CHAR *) (buf1) + align1; > + > + for (i = 0; i < len; ++i) > + s1[i] = 32 + 23 * i % (max_char - 32); > + s1[len] = 0; > + for (i = len + 1; (i + align1) * sizeof (CHAR) < page_size && i < len + 64; > + ++i) > + s1[i] = 32 + 32 * i % (max_char - 32); > + > + do_one_test (s1, len, n); > +} > + > +static void > +do_page_tests (void) > +{ > + CHAR *s1; > + const size_t maxoffset = 64; > + > + /* Put s1 at the maxoffset from the edge of buf1's last page. */ > + s1 = (CHAR *) buf1 + BUF1PAGES * page_size / sizeof(CHAR) - maxoffset; Space after 'sizeof'. > + /* s2 needs room to put a string with size of maxoffset + 1 at s2 + > + (maxoffset - 1). */ > + > + MEMSET (s1, 'a', maxoffset - 1); > + s1[maxoffset - 1] = '\0'; > + > + /* Both strings are bounded to a page with read/write access and the next > + page is protected with PROT_NONE (meaning that any access outside of the > + page regions will trigger an invalid memory access). > + > + The loop copies the string s1 for all possible offsets up to maxoffset > + for both inputs with a size larger than s1 (so memory access outside the > + expected memory regions might trigger invalid access). */ > + > + for (size_t off1 = 0; off1 < maxoffset; off1++) > + { > + for (size_t off2 = 0; off2 < maxoffset; off2++) > + { > + do_one_test (s1 + off1, maxoffset - off1 - 1, > + maxoffset + (maxoffset - off2)); > + } > + } > +} No need to brackets for single line code. > + > +static void > +do_random_tests (void) > +{ > + size_t i, j, n, align1, align2, len, size, mode; > + UCHAR *p1 = (UCHAR *) (buf1 + page_size) - 512; > + UCHAR *res; > + > + for (n = 0; n < ITERATIONS; n++) > + { > + /* For wcsndup: align1 and align2 here mean align not in bytes, > + but in wchar_ts, in bytes it will equal to align * (sizeof > + (wchar_t)). */ Same as before. > + > + mode = random (); > + if (mode & 1) > + { > + size = random () & 255; > + align1 = 512 - size - (random () & 15); > + if (mode & 2) > + align2 = align1 - (random () & 24); > + else > + align2 = align1 - (random () & 31); > + if (mode & 4) > + { > + j = align1; > + align1 = align2; > + align2 = j; > + } > + if (mode & 8) > + len = size - (random () & 31); > + else > + len = 512; > + if (len >= 512) > + len = random () & 511; > + } > + else > + { > + align1 = random () & 31; > + if (mode & 2) > + align2 = random () & 31; > + else > + align2 = align1 + (random () & 24); > + len = random () & 511; > + j = align1; > + if (align2 > j) > + j = align2; > + if (mode & 4) > + { > + size = random () & 511; > + if (size + j > 512) > + size = 512 - j - (random () & 31); > + } > + else > + size = 512 - j; > + if ((mode & 8) && len + j >= 512) > + len = 512 - j - (random () & 7); > + } > + j = len + align1 + 64; > + if (j > 512) > + j = 512; > + for (i = 0; i < j; i++) > + { > + if (i == len + align1) > + p1[i] = 0; > + else > + { > + p1[i] = random () & BIG_CHAR; > + if (i >= align1 && i < len + align1 && !p1[i]) > + p1[i] = (random () & SMALL_CHAR) + 3; > + } > + } > + > + res = (UCHAR *) strndup ((CHAR *) (p1 + align1), size); > + j = len + 1; > + if (size < j) > + j = size; > + TEST_COMPARE_BLOB (res, j, (CHAR *) (p1 + align1), j); > + free (res); > + } > +} > + > +int > +test_main (void) > +{ > + size_t i; > + > + test_init (); > + > + printf ("%28s", ""); > + printf ("\t%s", TEST_NAME); > + putchar ('\n'); > + > + for (i = 1; i < 8; ++i) > + { > + do_test (i, i, 16, 16, SMALL_CHAR); > + do_test (i, i, 16, 16, BIG_CHAR); > + do_test (i, 2 * i, 16, 16, SMALL_CHAR); > + do_test (2 * i, i, 16, 16, BIG_CHAR); > + do_test (8 - i, 2 * i, 1 << i, 2 << i, SMALL_CHAR); > + do_test (2 * i, 8 - i, 2 << i, 1 << i, SMALL_CHAR); > + do_test (8 - i, 2 * i, 1 << i, 2 << i, BIG_CHAR); > + do_test (2 * i, 8 - i, 2 << i, 1 << i, BIG_CHAR); > + } > + > + for (i = 1; i < 8; ++i) > + { > + do_test (0, 0, 4 << i, 8 << i, SMALL_CHAR); > + do_test (0, 0, 16 << i, 8 << i, SMALL_CHAR); > + do_test (8 - i, 2 * i, 4 << i, 8 << i, SMALL_CHAR); > + do_test (8 - i, 2 * i, 16 << i, 8 << i, SMALL_CHAR); > + } > + > + do_random_tests (); > + do_page_tests (); > + return ret; > +} > + > +#include