From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Joseph Myers <joseph@codesourcery.com>,
Florian Weimer <fweimer@redhat.com>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Linux: Implement interfaces for memory protection keys
Date: Tue, 07 Nov 2017 02:16:00 -0000 [thread overview]
Message-ID: <11b4d352-79cb-d1a4-b48e-365ca6b0a2aa@linaro.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1711062257010.30112@digraph.polyomino.org.uk>
On 06/11/2017 20:59, Joseph Myers wrote:
> On Mon, 6 Nov 2017, Florian Weimer wrote:
>
>>>> diff --git a/sysdeps/unix/sysv/linux/syscalls.list
>>>> b/sysdeps/unix/sysv/linux/syscalls.list
>>>> index 40c4fbb9ea..6f657eea2e 100644
>>>> --- a/sysdeps/unix/sysv/linux/syscalls.list
>>>> +++ b/sysdeps/unix/sysv/linux/syscalls.list
>>>> @@ -110,3 +110,6 @@ setns EXTRA setns i:ii setns
>>>> process_vm_readv EXTRA process_vm_readv i:ipipii process_vm_readv
>>>> process_vm_writev EXTRA process_vm_writev i:ipipii process_vm_writev
>>>> memfd_create EXTRA memfd_create i:si memfd_create
>>>> +pkey_alloc EXTRA pkey_alloc i:ii pkey_alloc
>>>> +pkey_free EXTRA pkey_free i:i pkey_free
>>>> +pkey_mprotect EXTRA pkey_mprotect i:aiii pkey_mprotect
>>>
>>> I do not think we can them as default since build against kernel headers
>>> older than v4.9 won't have __NR_pkey_{alloc,free,mprotect). We need
>>> default implementation with #ifdef __NR_....
>>
>> Hmm. I checked that we'd fall back to an ENOSYS stub, but this was for
>> memfd_create, which had the stub in the generic API. That won't apply here,
>> so I will have to rework this a bit.
>
> I'd expect the stub-syscalls code in sysdeps/unix/Makefile to apply here.
> These entries are essentially much like the bdflush one, which exercises
> the ENOSYS generation on x86_64 as a syscall not existing there.
>
Indeed this is what happens for non defined __NR_ syscalls, sorry for the trouble.
prev parent reply other threads:[~2017-11-07 2:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-04 17:49 Florian Weimer
2017-11-05 7:35 ` Florian Weimer
2017-11-06 13:29 ` Joseph Myers
2017-11-06 13:40 ` Florian Weimer
2017-11-06 16:49 ` Adhemerval Zanella
2017-11-06 20:01 ` Florian Weimer
2017-11-06 21:46 ` Adhemerval Zanella
2017-11-06 22:03 ` Florian Weimer
2017-11-07 19:59 ` Adhemerval Zanella
2017-11-23 14:36 ` Florian Weimer
2017-11-28 19:02 ` Adhemerval Zanella
2017-12-01 16:30 ` Florian Weimer
2017-12-05 13:52 ` Florian Weimer
2017-12-05 14:06 ` Adhemerval Zanella
2017-12-05 14:18 ` Florian Weimer
2017-11-06 22:59 ` Joseph Myers
2017-11-07 2:16 ` Adhemerval Zanella [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=11b4d352-79cb-d1a4-b48e-365ca6b0a2aa@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).