public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Andreas Schwab <schwab@suse.de>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH] Fix handling of collating elements in fnmatch (bug 17396, bug 16976)
Date: Thu, 10 Jan 2019 12:25:00 -0000	[thread overview]
Message-ID: <11d6af0b-9674-0f5b-1966-68d612bf637c@linaro.org> (raw)
In-Reply-To: <mvmpnt4ewca.fsf@suse.de>



On 10/01/2019 06:43, Andreas Schwab wrote:
> On Jan 09 2019, Adhemerval Zanella <adhemerval.zanella@linaro.org> wrote:
> 
>> On 09/01/2019 12:31, Andreas Schwab wrote:
>>> diff --git a/sysdeps/i386/i686/multiarch/wmemcmp.c b/posix/tst-fnmatch4.c
>>> similarity index 59%
>>> copy from sysdeps/i386/i686/multiarch/wmemcmp.c
>>> copy to posix/tst-fnmatch4.c
>>> index ce25991352..370265ddf0 100644
>>> --- a/sysdeps/i386/i686/multiarch/wmemcmp.c
>>> +++ b/posix/tst-fnmatch4.c
>>> @@ -1,6 +1,5 @@
>>> -/* Multiple versions of wmemcmp.
>>> -   All versions must be listed in ifunc-impl-list.c.
>>> -   Copyright (C) 2017-2019 Free Software Foundation, Inc.
>>
>> I think something is wrong with git format-patch here.
> 
> I which way?

It is kind hard to evaluate the changes when diff is against unrelated files.

  reply	other threads:[~2019-01-10 12:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-11 15:55 Andreas Schwab
2019-01-07 15:26 ` Florian Weimer
2019-01-09 13:20   ` Andreas Schwab
2019-01-09 13:35     ` Adhemerval Zanella
2019-01-09 14:32       ` Andreas Schwab
2019-01-09 18:33         ` Adhemerval Zanella
2019-01-10  8:43           ` Andreas Schwab
2019-01-10 12:25             ` Adhemerval Zanella [this message]
2019-01-10 13:20               ` Andreas Schwab
2019-01-09 14:05     ` Florian Weimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=11d6af0b-9674-0f5b-1966-68d612bf637c@linaro.org \
    --to=adhemerval.zanella@linaro.org \
    --cc=libc-alpha@sourceware.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).