From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (mail.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id C1EE63858D1E for ; Fri, 2 Sep 2022 17:29:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C1EE63858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org From: "Andreas K. Huettel" To: libc-alpha@sourceware.org, glaubitz@physik.fu-berlin.de Cc: Adhemerval Zanella Subject: Re: [PATCH] m68: Enforce 4-byte alignment on internal locks (BZ #29537) Date: Fri, 02 Sep 2022 19:29:03 +0200 Message-ID: <12045544.O9o76ZdvQC@pinacolada> Organization: Gentoo Linux In-Reply-To: <20220830133504.2669323-1-adhemerval.zanella@linaro.org> References: <20220830133504.2669323-1-adhemerval.zanella@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-Spam-Status: No, score=-9.6 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: Am Dienstag, 30. August 2022, 15:35:04 CEST schrieb Adhemerval Zanella via = Libc-alpha: > The HPPA also requires a 16-byte alignment for locks, although it is > just a historical artifact to keep compatibility with old > implementation. > --- > sysdeps/nptl/libc-lockP.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sysdeps/nptl/libc-lockP.h b/sysdeps/nptl/libc-lockP.h > index d3a6837fd2..9efe962588 100644 > --- a/sysdeps/nptl/libc-lockP.h > +++ b/sysdeps/nptl/libc-lockP.h > @@ -34,7 +34,7 @@ > #include > =20 > /* Mutex type. */ > -typedef int __libc_lock_t; > +typedef int __libc_lock_t __LOCK_ALIGNMENT; > typedef struct { pthread_mutex_t mutex; } __rtld_lock_recursive_t; > typedef pthread_rwlock_t __libc_rwlock_t; > =20 >=20 I've added this to glibc-2.35, recompiled and reinstalled glibc, and was th= en=20 able to=20 * update my qemu-m68k chroot to newest packages * and have it rebuild itself fully at MAKEOPTS=3D"-j17" without any issues.=20 (This means, whereas building python always failed before, now I built pyth= on-3.10 and python-3.11 each twice, without problems. The chroot contains the Gentoo @system set, so glibc, binutils, gcc, ...) So, LGTM and thank you!!! =2D-=20 Andreas K. H=FCttel dilfridge@gentoo.org Gentoo Linux developer (council, toolchain, base-system, perl, libreoffice)