From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-oi1-x235.google.com (mail-oi1-x235.google.com [IPv6:2607:f8b0:4864:20::235]) by sourceware.org (Postfix) with ESMTPS id BB1883858400 for ; Tue, 25 Jan 2022 17:07:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB1883858400 Received: by mail-oi1-x235.google.com with SMTP id e81so32238317oia.6 for ; Tue, 25 Jan 2022 09:07:35 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=HKaqfCPTNYcHT/RiwbsAV17D8JCm78x24Uk7XgQFX8E=; b=V+H9CrACFzaguM/BwOPy10ybizlP3J9AaNMa2Zo/CLH76tprIfYJbgz8TpttcEExMZ 01n3LMPBwYdMpX70q9djVDqH/MGGeHCXBSsMk/lm7K+WPrUJgXVzoWrfGjtf0cBGwetQ 5rjIilVtfft41BaqB0fYa8OmzqS0wLWza+bJ6CyWf97o+26y3/YERSsMQxAnvY+u3ttP KvSl19IYmD2WB64C0uABTqGE9mJnVHo3W1yAVEfvdDz//Qzw5cAU4GD96aZVI5R9eYj5 Ox/WLMnxrlFC+tUwsalgNlkJ37fyF7Jc+9so9+oMTWkdDIKP9ucYcXWhNWTQZ3Scw0bV HKXw== X-Gm-Message-State: AOAM5313LheQYyRoh9IyOnomwFp7738W9Ga+1ELDlAGs2aIWkrHD5h1q CH2AYLFM/LTOcNBkfpFe/ySxtw== X-Google-Smtp-Source: ABdhPJweb6mB+RGerCd6Pm6zMmYPlBUnorJRqynJJ7yTzQfbl9aVJQhEF+g7nPY7yF1Pe2v12AY7jQ== X-Received: by 2002:a05:6808:2012:: with SMTP id q18mr1172166oiw.246.1643130455134; Tue, 25 Jan 2022 09:07:35 -0800 (PST) Received: from ?IPV6:2804:431:c7cb:27f8:5bed:1499:268c:5587? ([2804:431:c7cb:27f8:5bed:1499:268c:5587]) by smtp.gmail.com with ESMTPSA id n4sm3331180otr.76.2022.01.25.09.07.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Jan 2022 09:07:34 -0800 (PST) Message-ID: <121ae1cd-87c5-399f-8a1e-f9d2e4618be0@linaro.org> Date: Tue, 25 Jan 2022 14:07:32 -0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [OpenRISC] [PATCH v5 00/13] Glibc OpenRISC port Content-Language: en-US To: Stafford Horne Cc: Florian Weimer , Openrisc , GLIBC patches References: <20220104031414.2416928-1-shorne@gmail.com> <87tudt2rpg.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.4 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 25 Jan 2022 17:07:37 -0000 On 24/01/2022 22:19, Stafford Horne wrote: > On Mon, Jan 24, 2022 at 10:54:58AM -0300, Adhemerval Zanella wrote: >> >> >> On 24/01/2022 10:23, Florian Weimer via Libc-alpha wrote: >>> * Stafford Horne: >>> >>>> This is the OpenRISC port for glibc that I have been working on. >>> >>> The port does not define PI_STATIC_AND_HIDDEN. Is this really >>> necessary, or just an oversight due to the way the port was constructed >>> (presumably with MIPS as the template)? >>> >>> PI_STATIC_AND_HIDDEN means that references to static functions and data >>> and symbols with hidden visibility do not need any run-time relocations >>> after the final link, with the build flags used by glibc. >> >> At least the loader with a simple hello world does not fail with qemu with >> PI_STATIC_AND_HIDDEN set. >> >> Staffork, could you confirm it is ok to make or1k use PI_STATIC_AND_HIDDEN? > > Yes, this was just an oversight and it didn't show up during testing. I think > this is OK as described or1k does not need runtime relocations for hidden > symbols after the final link. > > Shall I make the patch to add configure.ac? Or do you have that ready to go > already? I would tested briefly with qemu-system, I will send a patch so you can review.