public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Carlos O'Donell <carlos@redhat.com>
To: Florian Weimer <fweimer@redhat.com>,
	Carlos O'Donell via Libc-alpha <libc-alpha@sourceware.org>
Cc: Adhemerval Zanella Netto <adhemerval.zanella@linaro.org>
Subject: Re: Should we make DT_HASH dynamic section for glibc?
Date: Fri, 30 Sep 2022 08:56:59 -0400	[thread overview]
Message-ID: <128f4264-d3da-9b04-e567-89b4e73fe299@redhat.com> (raw)
In-Reply-To: <87bkstn566.fsf@oldenburg.str.redhat.com>

On 8/9/22 05:21, Florian Weimer wrote:
> * Carlos O'Donell via Libc-alpha:
> 
>>> So the question is whether we should enforce at least on glibc by reverting
>>> e47de5cb2d4dbec.  It does sounds muddle to keep this solely on glibc, where
>>> rest of the system is not enforcing it, and only for compatibility with an
>>> obscure tools where there is no much information on why it requires it.
>>
>> The tool is EAC.
>>
>> It is EPICs "Easy Anti-Cheat" (https://www.easy.ac/en-us/) and like
>> other non-standard consumers it has to know some specific ELF details.
>>
>> The game "Rogue Company" is known to use EAC and is likely broken by
>> this change.
> 
> I think there are several other glibc patches required to fix Rogue
> Company?
> 
> <https://github.com/GloriousEggroll/glibc-eac-rc> (“glibc with reverts
> applied to allow Rogue Company to work with EasyAntiCheat”) makes the
> following changes:
> 
> · Install shared objects under traditional versioned nmaes.
> · Bring back various GLIBC_PRIVATE symbols.
> · Disable clone3.
> 
> If EasyAntiCheat has been fixed for those, surely it can be fixed to use
> DT_GNU_HASH as well.

The fix is available in version 1.15.2 of the EOS SDK and in the new
corresponding version of the anti-cheat module. This was released in August.

Fixing this issue though requires several steps that need to be taken by the
developers of the game itself.

The issue therefore has direct impact on users of these binaries, and we can
help lessen that impact by adding back DT_HASH. Making this change upstream
has value for all the distributions that want to support these games.

I am evaluating this change in isolation and weighing the pros and cons of
just this change. As you note there are other changes impact other games and
this speaks to me of a disconnect with how Linux is developed versus how these
specific applications are being developed. That's something we can work on
together as a community by engaging developers directly to see how their
workflow maps to our update process.

Looking across the distributions some of them are carrying a revert that adds
back DT_HASH. Therefore I think it would help the distributions and add
back DT_HASH support for a longer period of time before final removal.

I don't think this will solve all the problems, but I will work to test out
the revert on my Fedora system.

-- 
Cheers,
Carlos.


  reply	other threads:[~2022-09-30 12:57 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-08 17:31 Adhemerval Zanella Netto
2022-08-08 20:40 ` Carlos O'Donell
2022-08-08 20:56   ` Carlos O'Donell
2022-08-08 22:59   ` Fangrui Song
2022-08-08 23:36     ` Sam James
2022-08-09  9:21   ` Florian Weimer
2022-09-30 12:56     ` Carlos O'Donell [this message]
2022-10-01  7:40       ` Fangrui Song
2022-10-01  8:31         ` Sam James
2022-10-01  8:41           ` Andreas Schwab
2022-10-01 13:49             ` Florian Weimer
2022-10-03 20:57             ` Michael Hudson-Doyle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=128f4264-d3da-9b04-e567-89b4e73fe299@redhat.com \
    --to=carlos@redhat.com \
    --cc=adhemerval.zanella@linaro.org \
    --cc=fweimer@redhat.com \
    --cc=libc-alpha@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).