From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id B11833858289 for ; Wed, 24 Jan 2024 16:43:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B11833858289 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B11833858289 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706114603; cv=none; b=iMHbhRCNG5k/bv/2GFPx3d572FPrPZqU7gN8k166B2qx6IsdOF9VJ6VYX2Z6+z4YH+8mNCXik08+jvP0oC1bQn0SNp8eklXfx0m5uZQr5yScLysne+KPolpcjecccnXMHZt3Cv0mpvfY81xvjS437xSx+0RhJqEpubCalR+d9+Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706114603; c=relaxed/simple; bh=hXtL+tbuHO6HzMIgtWgB9ODxnGgivMNnOM7V9JkztkM=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=gNAnoYL5niJL/+nvDtnLpfk7IisMPIChQ67tXtoBe5JJQLD/Yfd6BlRDrO9y/6T1bC6+niRvpec6tuxqMLzWXoy841LDMes5ody32qo6mvU6xJVIo2tuvEskIvZzEPnTTJh74X2ZrhQJq5mCaxGoO17/Np82GmlGZP+/KelntNc= ARC-Authentication-Results: i=1; server2.sourceware.org From: "Andreas K. Huettel" To: Dennis Brendel , libc-alpha@sourceware.org, Carlos O'Donell Subject: Re: [PATCH] Manual: fix order of arguments of memalign and aligned_alloc Date: Wed, 24 Jan 2024 17:42:56 +0100 Message-ID: <12931477.O9o76ZdvQC@kona> Organization: Gentoo Linux In-Reply-To: <393f9be7-164e-feb7-9952-f40b46688823@redhat.com> References: <779c4fcc-5dc9-4bc1-9d68-cbce31a0d8e7@redhat.com> <393f9be7-164e-feb7-9952-f40b46688823@redhat.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart6312821.DvuYhMxLoT"; micalg="pgp-sha512"; protocol="application/pgp-signature" X-Spam-Status: No, score=-9.7 required=5.0 tests=BAYES_00,GIT_PATCH_0,JMQ_SPF_NEUTRAL,KAM_DMARC_STATUS,SPF_HELO_PASS,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --nextPart6312821.DvuYhMxLoT Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1"; protected-headers="v1" From: "Andreas K. Huettel" Date: Wed, 24 Jan 2024 17:42:56 +0100 Message-ID: <12931477.O9o76ZdvQC@kona> Organization: Gentoo Linux In-Reply-To: <393f9be7-164e-feb7-9952-f40b46688823@redhat.com> MIME-Version: 1.0 Sure & thank you! -a Am Mittwoch, 24. Januar 2024, 17:25:18 CET schrieb Carlos O'Donell: > On 1/15/24 03:55, Dennis Brendel wrote: > > On the summary page the order of the function arguments was reversed, b= ut it is > > in correct order in the other places of the manual. >=20 > LGTM. >=20 > Confirmed PDF manual looks correct. >=20 > Andreas, May I please push the manual change? >=20 > This looks good to me and would correct the API descriptions. >=20 > Reviewed-by: Carlos O'Donell > =20 > > BZ #27547 > > --- > > manual/memory.texi | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > >=20 > > diff --git a/manual/memory.texi b/manual/memory.texi > > index 258fdbd3a0..78b657627f 100644 > > --- a/manual/memory.texi > > +++ b/manual/memory.texi > > @@ -1502,7 +1502,7 @@ Space}. > > Allocate a block of @var{size} bytes, starting on a page boundary. > > @xref{Aligned Memory Blocks}. > > =20 > > -@item void *aligned_alloc (size_t @var{size}, size_t @var{alignment}) > > +@item void *aligned_alloc (size_t @var{alignment}, size_t @var{size}) >=20 > OK. This is correct, verified by checking the ISO C standard. >=20 > > Allocate a block of @var{size} bytes, starting on an address that is a > > multiple of @var{alignment}. @xref{Aligned Memory Blocks}. > > =20 > > @@ -1510,7 +1510,7 @@ multiple of @var{alignment}. @xref{Aligned Memor= y Blocks}. > > Allocate a block of @var{size} bytes, starting on an address that is a > > multiple of @var{alignment}. @xref{Aligned Memory Blocks}. > > =20 > > -@item void *memalign (size_t @var{size}, size_t @var{boundary}) > > +@item void *memalign (size_t @var{boundary}, size_t @var{size}) >=20 > OK. This is correct, verified against deployed malloc.h and BSD memalign(= ). >=20 > > Allocate a block of @var{size} bytes, starting on an address that is a > > multiple of @var{boundary}. @xref{Aligned Memory Blocks}. > > =20 >=20 >=20 =2D-=20 Andreas K. H=FCttel dilfridge@gentoo.org Gentoo Linux developer (council, toolchain, base-system, perl, libreoffice) --nextPart6312821.DvuYhMxLoT Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQKTBAABCgB9FiEE/Rnm0xsZLuTcY+rT3CsWIV7VQSoFAmWxPhBfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldEZE MTlFNkQzMUIxOTJFRTREQzYzRUFEM0RDMkIxNjIxNUVENTQxMkEACgkQ3CsWIV7V QSr3lxAAoVId6r6YYrKHaXakIqsOM49jMSbd3FJFVpI+CapaRSmscethEkfLaVJu Stl89GQhHHBBLgvLpLfnVLa9Lk9z5BVsr9lmDGsW35UQNN5/9FTA64i9OukZbc62 tZszo5FfnGK+scWUDqYEcEQOyAEcpdV7H6YD5hb99z12n47fEb/mtpKGGrg/wDl6 yZ+Mx3QELhYVFLmcR5cpZ8e+K5fabClPchph3/okLyhHq7cfyM3LhINj+n0rPT3I JPSePaDIW9BXp3lD6Sf6Hi4BXPNuL14dd/GkfjbqQH+L8MktuVhMVqLXwQdrD2Yw mFeyV2rRaydWc2yhWUzKqylgZwS5Bfa7BIxr6yC9Q9gfnN/YlJzRhTiESeJ/R7O8 LdY5fmw1i1j8wqXP4rndJHDw7chFt0KqROfp9kqwRJCr+d4YoweFHrFIS7JXDLgx Xbuv2/dhqsKzIerTiLovmyZoAuS933Wp51Waz+N1QUz/EC0xZM1sPmXByXDyMc7a xJiP78vburgRBY1sXu2gJxGGab+f4SYc0SXcKajny8DCEVKU2YYcgOOj46j3Thws XozhLnwtIE5WhXTUaXxaFLhuAF33+GQaOGhf6RgnanbW0IrLjsWbkH/jPFCU1eXS 58wHcXz9Ox6xYJnXqN+/EIIZhbs3tsjuFmkxotKWMmSNE4Ec7I8= =21hF -----END PGP SIGNATURE----- --nextPart6312821.DvuYhMxLoT--