From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 102743 invoked by alias); 15 Sep 2017 20:27:03 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 102301 invoked by uid 89); 15 Sep 2017 20:27:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE,RCVD_IN_SORBS_SPAM,SPF_PASS autolearn=no version=3.3.2 spammy= X-HELO: mail-qt0-f174.google.com X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=8UoZaHuLQpXBMhZmXovjWdUImrFiMtrEW/V74HyIv1o=; b=CePc57zAuRA5pLY0ouO9sAuxoLWlPyJsGHrscW6hfEZEUS6ZTWza60Kw4o+FSbSXq/ C1Zn3vGEoYZD8AFj1JuOPLNRPc1dGUWloJOuctc12aCB4YJnGfPSzYZK1pz8BrySSQrf 6rC1xgaw7IuGp2otBbnLJZQxnNQCE8EsQymBmHLxIIGl9H/l6cQ8pSTPeStbbOPQnOzT 4gzkRz7hT6V72jnJ6SxQ6m6rBTdypXJtepMpMKWqNyimnlU/je8ciMHafVV1/HhCvLEp gSjaq/4g4mtJvHuOS5Tp3Q+PlREc/VvcFEIKRYQqojsLdiqP2ITLRWcNATfPDFsWNH87 9oxA== X-Gm-Message-State: AHPjjUgF9jjBTHIGsNDEVBPkqXkFe8vvwZSK94st9tBfYakdfFfsaGYA FL0dPu0VDFNaV9IstE8Szw== X-Google-Smtp-Source: AOwi7QCpy5nppQ6h5HL/ohRLVSoEUzYaWzUbADfOKqkIswcIrY0957HTeCG+bvDLUjefqA/sE6/wdQ== X-Received: by 10.200.35.153 with SMTP id q25mr39392031qtq.178.1505507220360; Fri, 15 Sep 2017 13:27:00 -0700 (PDT) Subject: Re: [PATCH 3/9] posix: Allow glob to match dangling symlinks [BZ #866] To: Florian Weimer , Paul Eggert , Zack Weinberg Cc: Joseph Myers , Andreas Schwab , GNU C Library References: <1504643122-14874-1-git-send-email-adhemerval.zanella@linaro.org> <1504643122-14874-4-git-send-email-adhemerval.zanella@linaro.org> <878thop5fa.fsf@linux-m68k.org> <9455e298-8c48-c42a-0ec3-ffb8d166c69b@linaro.org> <450d2eab-f21a-f90c-6210-ea638787e339@cs.ucla.edu> <403decc7-e039-9be1-fb44-25d611540156@linaro.org> <7bf58b8a-afc9-b934-9a4a-1616e71c03ff@cs.ucla.edu> <805e4d8a-de63-5253-e214-b3912ed221e3@cs.ucla.edu> <30b5f782-8fb0-5b38-3b4c-6ebf435bc91c@linaro.org> <95745cd2-0033-8a3c-92af-879c24d0d396@cs.ucla.edu> From: Adhemerval Zanella Message-ID: <12a22db1-aedd-43f0-da2f-04caa0d0988e@linaro.org> Date: Fri, 15 Sep 2017 20:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2017-09/txt/msg00657.txt.bz2 On 15/09/2017 17:18, Florian Weimer wrote: > On 09/13/2017 11:14 AM, Paul Eggert wrote: >> Although that's clever, it is a gratuitous source-code incompatibility with BSD, which is not a good thing. To some extent it's just GLOB_FOLLOW and GLOB_NOFOLLOW in disguise, and disguise is not a good thing in APIs. So I think I still prefer the compat symbol approach. > > If the BSDs are currently source-code-compatible, why doesn't GNU make fail there already? My understanding is BSDs were not current source-code-compatible before the dangling symlink fix (commit 5554304f0) since afaik both openbsd and freebsd do check for dangling symlinks (using gl_lstat if it is the case). Reverting back to ol GLOB_ALTDIRFUNC semantic with make glibc again source-code-incompatible and by adding an extra flag would require adjustments in the program source code to actually handle it.