From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x731.google.com (mail-qk1-x731.google.com [IPv6:2607:f8b0:4864:20::731]) by sourceware.org (Postfix) with ESMTPS id 709C4384BC17 for ; Wed, 17 Mar 2021 18:40:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 709C4384BC17 Received: by mail-qk1-x731.google.com with SMTP id f124so39948432qkj.5 for ; Wed, 17 Mar 2021 11:40:33 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=sOznc4R2cemDz5sei2Fh6+5wk2I3rCEfj1MGZIOztvw=; b=DYnUW7VV1BCT+rkLHpdRoUjIa4uaa5cImTZKN6Qd29q3SUILGO0zX4b2EjU4s1ooon DFZiS/drH7lW/rfbl96R7ZILCz0YnGk9bsy9o73zv4o6P+AS+33xakdmOXOzAikArC5y quSMVqkxmpzsGN4YmYA5Yzepb9jWkW25nzgi93CESVMXNR/G2rzWQdtORVYodzzptsfp 6uTbzhZdPlk5H9vwFWpdG3EbOE9wXHi33SPdzP0IdbrOdl56k7MN+UbEzlo/3SaAhqkQ g3Fdn/qgN7i6x9pGErgiFdDeut+8f/l8DGkQUFn30ZDBR6O7oWrDF7HkRBTzDGDauwIP SafA== X-Gm-Message-State: AOAM530NVX2Xu6qzoX6Z+A8ojaV8f7a0ocIhSleTtQ/A2qQF9md9tmnt sTF/YltqAQDyOSacpl/Y94yEWQZRn3mR5Sa7 X-Google-Smtp-Source: ABdhPJxL4pXpvaee6V67T0hEfugSZa0iOtwwtV7jhnWhS42w2AinjKpobDoKVJ+mX7LbT2YkdM5hKw== X-Received: by 2002:a05:620a:31a:: with SMTP id s26mr576955qkm.355.1616006432956; Wed, 17 Mar 2021 11:40:32 -0700 (PDT) Received: from [192.168.1.4] ([177.194.48.209]) by smtp.googlemail.com with ESMTPSA id f12sm15416640qti.63.2021.03.17.11.40.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Mar 2021 11:40:32 -0700 (PDT) Subject: Re: [PATCH 26/30] nptl: Remove pthread raise implementation To: Florian Weimer , Adhemerval Zanella via Libc-alpha References: <20210316200510.2135405-1-adhemerval.zanella@linaro.org> <20210316200510.2135405-27-adhemerval.zanella@linaro.org> <87k0q5zl0c.fsf@oldenburg.str.redhat.com> From: Adhemerval Zanella Message-ID: <12b2009b-a3f8-eecc-88a6-e0f4641f7a6f@linaro.org> Date: Wed, 17 Mar 2021 15:40:29 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <87k0q5zl0c.fsf@oldenburg.str.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.7 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP, URIBL_BLACK autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Mar 2021 18:40:36 -0000 On 17/03/2021 15:35, Florian Weimer wrote: > * Adhemerval Zanella via Libc-alpha: > >> The Linux version already target the current thread by using tgkill >> along with getpid and gettid. > > This needs to update localplt.data on the targets that call raise from > libgcc (such as arm-linux-gnueabi). The call still uses a PLT, but > that's expected because raise is not locally defined anymore. Yes, I just found this very issue. As a side note, I think we can remove even the raise call from libc.so using the same trick sparcv32 does for .udiv.