From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by sourceware.org (Postfix) with ESMTPS id DABBE385B504 for ; Wed, 1 Feb 2023 17:56:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org DABBE385B504 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-pj1-x1035.google.com with SMTP id ha3-20020a17090af3c300b00230222051a6so2775002pjb.2 for ; Wed, 01 Feb 2023 09:56:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=C2g4YdgoWhs6hlA4/56iaaiWA87yhC21D0DFnuswK4Q=; b=EYsbVVrjKFFHFYi2xZMytA6tfa2vxpx6oDtFgtiV9A6FP47YB0ZQ2nRlX1jx0td5R2 3v8dtSNRMB8TA3g+eXtLOyLN0uNhyDcXjgPptBp2Ot2clkiGfZJrL6ORHsSgZJvTpcSU PlfR2+I05fgWHWezvBao2GFP3VXxnGFrFhyycotoPYLxIAkz6QIqx695rRkSVoch+MAG 6WUP/o+xO9zpk6Q34W+zgM6wvmbFlu52H91SlxB1fA95zVV9YoKy34Te02W5F/QWknO2 fO3b1EID4jIkxnfIYRdknB/ne2AuUFJi1pbMIzrdGjjIUr2q2k7zIpyWhyuArceGl8Rc 7eSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=C2g4YdgoWhs6hlA4/56iaaiWA87yhC21D0DFnuswK4Q=; b=1R9qheb086SmOuOZ1UJnmMFvgpOxl5s+0/lnc2MWNh+hiNAn/TvVdj4nyLHUcCFoY/ STR9GcQj+WbKyqCCn7UstqdF1QoIY5n2MmSMkcu2vouW+ZIJvIijLJxSTG4WD5A4hVPL zHUyzI7cKTJ0WEgA1MjIVpj7UJpFi33a94nriwpf7GZtci71B7jpwG7BJ7E2ZUnI0qQx pNK1ClcXWXkQ00+/sgjyAOkrm7QD3a58/KCtgtDE2yyGqvKxq8BPZrxxrPH6BK+hB8p3 eKbghL/Ja2sF4xq5xdWzExRmrNtW/xTs7m6Fwm2ornqH4aOlqH5s8+EDJHihMWW3deV6 PGFg== X-Gm-Message-State: AO0yUKV9Sv210nzQmU8JqywzYpnPNGhH+asX9xK4EAs2sAI3y33bmZQp Sze9n6481me2epQkihVdl6RApw== X-Google-Smtp-Source: AK7set+80t+h/hu/TYKoZv0fzN6NSVdztl4qdRpmy+CyXERqPUNBkJtainzIrd3lMCL9wKwTOmEe4A== X-Received: by 2002:a05:6a21:329f:b0:b8:bcfb:7ae6 with SMTP id yt31-20020a056a21329f00b000b8bcfb7ae6mr20103132pzb.23.1675274167009; Wed, 01 Feb 2023 09:56:07 -0800 (PST) Received: from [192.168.50.50] (rrcs-173-197-98-118.west.biz.rr.com. [173.197.98.118]) by smtp.gmail.com with ESMTPSA id f9-20020a639c09000000b004b4d4de54absm9858490pge.59.2023.02.01.09.56.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 09:56:06 -0800 (PST) Message-ID: <131e11a5-aba8-6aea-bca7-6b8bdf56e5a4@linaro.org> Date: Wed, 1 Feb 2023 07:56:03 -1000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH v11 25/29] string: Hook up the default implementation on test-strncmp Content-Language: en-US To: Adhemerval Zanella , libc-alpha@sourceware.org, Noah Goldstein , Jeff Law , Xi Ruoyao References: <20230201170406.303978-1-adhemerval.zanella@linaro.org> <20230201170406.303978-26-adhemerval.zanella@linaro.org> From: Richard Henderson In-Reply-To: <20230201170406.303978-26-adhemerval.zanella@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-11.5 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/1/23 07:04, Adhemerval Zanella wrote: > --- > string/test-strncmp.c | 16 ++++++++++++++++ > 1 file changed, 16 insertions(+) Reviewed-by: Richard Henderson r~ > > diff --git a/string/test-strncmp.c b/string/test-strncmp.c > index fb4c6420b8..35dc496eae 100644 > --- a/string/test-strncmp.c > +++ b/string/test-strncmp.c > @@ -90,6 +90,22 @@ typedef int (*proto_t) (const CHAR *, const CHAR *, size_t); > > IMPL (STRNCMP, 1) > > +/* Also check the default implementation. */ > +#undef STRNCMP > +#undef libc_hidden_builtin_def > +#define libc_hidden_builtin_def(a) > +#undef attribute_hidden > +#define attribute_hidden > +#ifndef WIDE > +# define STRNCMP __strncmp_default > +# include "string/strncmp.c" > +# define STRNCMP_DEFAULT STRNCMP > +#else > +# define WCSNCMP __wcsncmp_default > +# include "wcsmbs/wcsncmp.c" > +# define STRNCMP_DEFAULT WCSNCMP > +#endif > +IMPL (STRNCMP_DEFAULT, 1) > > static int > check_result (impl_t *impl, const CHAR *s1, const CHAR *s2, size_t n,