From: Paul Eggert <eggert@cs.ucla.edu>
To: Zack Weinberg <zackw@panix.com>,
libc-alpha@sourceware.org, joseph@codesourcery.com,
adhemerval.zanella@linaro.org, Wilco.Dijkstra@arm.com,
fweimer@redhat.com
Subject: Re: [PATCH] explicit_bzero final
Date: Tue, 13 Dec 2016 01:58:00 -0000 [thread overview]
Message-ID: <1346ae87-12b8-bbd4-5d6b-aac4670aafda@cs.ucla.edu> (raw)
In-Reply-To: <20161212230622.14045-1-zackw@panix.com>
A couple of very minor nits in the documentation:
> +Having said all that, in most situations, using @code{explicit_bzero}
Please remove second comma. Otherwise "in most situations" can be misread as
applying to "Having said all that".
> by defining it to call memset() and then a second function,
> ...
> + intended to be used instead of memset() to erase sensitive data after use;
In the commit message and NEWS file, please use just 'memset' and not
'memset()', as the comments talk about the function, not about argument-free
calls to the function.
next prev parent reply other threads:[~2016-12-13 1:58 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 23:06 Zack Weinberg
2016-12-13 1:58 ` Paul Eggert [this message]
2016-12-13 7:02 ` Florian Weimer
2016-12-13 15:53 ` Zack Weinberg
2016-12-13 22:47 ` Jeff Law
2016-12-14 1:04 ` Zack Weinberg
2016-12-14 1:05 ` Zack Weinberg
2016-12-14 13:15 ` Florian Weimer
2016-12-14 17:06 ` Florian Weimer
2016-12-14 22:28 ` Zack Weinberg
2016-12-14 22:37 ` Joseph Myers
2016-12-15 9:08 ` Florian Weimer
2016-12-15 10:20 ` Florian Weimer
2016-12-15 23:31 ` Zack Weinberg
2016-12-16 7:50 ` Florian Weimer
2016-12-14 16:58 ` Jeff Law
2016-12-14 23:11 ` Zack Weinberg
2016-12-15 5:25 ` Jeff Law
2016-12-15 23:21 ` Zack Weinberg
2016-12-16 18:26 ` Jeff Law
2016-12-16 21:35 ` Zack Weinberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1346ae87-12b8-bbd4-5d6b-aac4670aafda@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=Wilco.Dijkstra@arm.com \
--cc=adhemerval.zanella@linaro.org \
--cc=fweimer@redhat.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
--cc=zackw@panix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).