From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 80656 invoked by alias); 7 Nov 2016 17:32:33 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 80642 invoked by uid 89); 7 Nov 2016 17:32:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.7 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=gomes X-HELO: mx1.redhat.com Subject: Re: [PATCH 2/2] Add write_message_to_stderr and use it instead of write To: "Gabriel F. T. Gomes" , libc-alpha@sourceware.org References: <1477961028-12150-1-git-send-email-gftg@linux.vnet.ibm.com> <1477961028-12150-3-git-send-email-gftg@linux.vnet.ibm.com> From: Florian Weimer Message-ID: <1360b678-e145-a434-fd14-3d1d69b7239b@redhat.com> Date: Mon, 07 Nov 2016 17:32:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1477961028-12150-3-git-send-email-gftg@linux.vnet.ibm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00248.txt.bz2 On 11/01/2016 01:43 AM, Gabriel F. T. Gomes wrote: > > +/* Write a message to standard error. Can be used in signal handlers. */ > +static void > +__attribute__ ((unused)) > +write_message_to_stderr (const char *message) > +{ > + ssize_t unused __attribute__ ((unused)); > + unused = write (STDERR_FILENO, message, strlen (message)); > +} These messages should really go to standard output, so you can adjust the tests to use plain write_message instead and drop this hunk. Thanks, Florian