From: Adhemerval Zanella <adhemerval.zanella@linaro.org>
To: Paul Zimmermann <Paul.Zimmermann@inria.fr>
Cc: libc-alpha@sourceware.org
Subject: Re: [PATCH 3/9] Fix the inaccuracy of j1f (BZ 14470) and y1f (BZ 14472)
Date: Tue, 30 Mar 2021 15:09:00 -0300 [thread overview]
Message-ID: <1387c05a-c49d-b89f-d818-d8eb68b666ec@linaro.org> (raw)
In-Reply-To: <mwsg4cttze.fsf@tomate.loria.fr>
On 30/03/2021 14:46, Paul Zimmermann wrote:
> Dear Adhemerval,
>
>> LGTM, with just nits below (there is no need to resend it).
>
>>> + float cst = 0xc.c422ap-4; /* sqrt(2/pi) rounded to nearest */
>
>> Double space before '*/;'.
>
> I guess you mean before '*/' (i.e., after 'nearest').
Yeap.
>
>> Right, so this new patch supersedes this whole set?
>
> yes it does. If/when you are done with your review, I can submit a new version
> with the nits above corrected.
I think besides the xfail for powerpc and comment nits the whole set
seems to good. I will mark the set superseded and ack the new version
(you can fix the commits nits before commit, there is no need to
resend a newer version).
next prev parent reply other threads:[~2021-03-30 18:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 15:06 [PATCH 1/9] Auxiliary function for reduction modulo 2*pi Paul Zimmermann
2021-03-19 15:06 ` [PATCH 2/9] Fix the inaccuracy of j0f and of y0f [BZ #14469 and #14471] Paul Zimmermann
2021-03-30 16:59 ` Adhemerval Zanella
2021-03-19 15:06 ` [PATCH 3/9] Fix the inaccuracy of j1f (BZ 14470) and y1f (BZ 14472) Paul Zimmermann
2021-03-30 17:27 ` Adhemerval Zanella
2021-03-30 17:46 ` Paul Zimmermann
2021-03-30 18:09 ` Adhemerval Zanella [this message]
2021-03-19 15:06 ` [PATCH 4/9] Added new entries for j0/j1/y0/y1 and regenerate ulps Paul Zimmermann
2021-03-30 16:13 ` Adhemerval Zanella
2021-03-19 15:06 ` [PATCH 5/9] ulps update for sparc (from Adhemerval Zanella) Paul Zimmermann
2021-03-19 15:06 ` [PATCH 6/9] ulps update for s390 " Paul Zimmermann
2021-03-19 15:06 ` [PATCH 7/9] ulps update for aarch64 " Paul Zimmermann
2021-03-19 15:06 ` [PATCH 8/9] ulps update for powerpc " Paul Zimmermann
2021-03-19 15:06 ` [PATCH 9/9] ulps update for x86_64 Paul Zimmermann
2021-03-30 12:51 ` [PATCH 1/9] Auxiliary function for reduction modulo 2*pi Adhemerval Zanella
2021-03-30 17:24 ` Paul Zimmermann
2021-03-30 17:28 ` Adhemerval Zanella
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1387c05a-c49d-b89f-d818-d8eb68b666ec@linaro.org \
--to=adhemerval.zanella@linaro.org \
--cc=Paul.Zimmermann@inria.fr \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).