From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-x72d.google.com (mail-qk1-x72d.google.com [IPv6:2607:f8b0:4864:20::72d]) by sourceware.org (Postfix) with ESMTPS id 03B043858002 for ; Tue, 30 Mar 2021 18:09:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 03B043858002 Received: by mail-qk1-x72d.google.com with SMTP id c3so16769395qkc.5 for ; Tue, 30 Mar 2021 11:09:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5Q8gO1Vd/OXJuJU8Dm+aG4VteZhSqG0T9t9pnqHMqCU=; b=K1rqVL4/JC8PXrdL2M4/6jSCwtcUuKnz4o6YzBRpGpQvZpH7l/gf932X2G73MmPohI bgU+1Gc5kz8aDJjl/peq//3hZe1zJbX9Fh1W1Ksb2KvoAbchMxbHUjbVqtd8HfTYLY/o pgWEif4zESUB8pvoIEtaYgiGarvs9qqs7uFafsam54qnWgR5JyzoesfkXS73C0qWCV0i intBfI2weynyo7O88XQH0sDGlQcbOs17Kxoyg4pU3SlDhV/VWzrQ1mirgsLpIezK99yu Ddasd2Nj20XTDFiUVCjoSu2HhbyrBWqBSWoo/JkZAUL7m1iAJ7ns59D2Pup5zkXt0zj/ J7mA== X-Gm-Message-State: AOAM530S/bM4qYsrA5VtT8Sm6xZrs5DWEgWTeKR9oyEVmtybW9dbkHUU 81hVVrGwTl8rM2X5L2xDG3qO/0KprGMQLg== X-Google-Smtp-Source: ABdhPJzBC+IpqkYRmrqLD6jgRKX477EU5LbRM5rvtOKNS/CIa9azD7DXsr84aG0B5UBY61wG9kox2w== X-Received: by 2002:a37:7c87:: with SMTP id x129mr31188400qkc.293.1617127744387; Tue, 30 Mar 2021 11:09:04 -0700 (PDT) Received: from ?IPv6:2804:14c:485:832:785f:747b:4f53:8c80? ([2804:14c:485:832:785f:747b:4f53:8c80]) by smtp.gmail.com with ESMTPSA id l6sm16362017qke.34.2021.03.30.11.09.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 30 Mar 2021 11:09:04 -0700 (PDT) Subject: Re: [PATCH 3/9] Fix the inaccuracy of j1f (BZ 14470) and y1f (BZ 14472) To: Paul Zimmermann Cc: libc-alpha@sourceware.org References: <20210319150626.1206905-1-Paul.Zimmermann@inria.fr> <20210319150626.1206905-3-Paul.Zimmermann@inria.fr> From: Adhemerval Zanella Message-ID: <1387c05a-c49d-b89f-d818-d8eb68b666ec@linaro.org> Date: Tue, 30 Mar 2021 15:09:00 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: libc-alpha@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Libc-alpha mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Mar 2021 18:09:06 -0000 On 30/03/2021 14:46, Paul Zimmermann wrote: > Dear Adhemerval, > >> LGTM, with just nits below (there is no need to resend it). > >>> + float cst = 0xc.c422ap-4; /* sqrt(2/pi) rounded to nearest */ > >> Double space before '*/;'. > > I guess you mean before '*/' (i.e., after 'nearest'). Yeap. > >> Right, so this new patch supersedes this whole set? > > yes it does. If/when you are done with your review, I can submit a new version > with the nits above corrected. I think besides the xfail for powerpc and comment nits the whole set seems to good. I will mark the set superseded and ack the new version (you can fix the commits nits before commit, there is no need to resend a newer version).