From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from s02.bc.larksuite.com (s02.bc.larksuite.com [209.127.230.20]) by sourceware.org (Postfix) with UTF8SMTPS id C79303858C30 for ; Thu, 1 Jun 2023 09:17:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C79303858C30 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=oss.cipunited.com Authentication-Results: sourceware.org; spf=none smtp.mailfrom=oss.cipunited.com DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; s=feishu2303200042; d=oss.cipunited.com; t=1685611040; h=from:subject:mime-version:from:date:message-id:subject:to:cc: reply-to:content-type:mime-version:in-reply-to:message-id; bh=qaTb4jVCgXBHVyQP2VECSSCOS5ieDgjLuMIfEXQQKhc=; b=6xNzlMnHyuk0bSNu3HX0UD1Qdsld66MlB24Vgul796FJfvrabCgiUgyDzqssPnlrDt8mro Xqajycu1wmwlZ1RRAwTvK9FShoy2wDOX1ej/kbiShSP5XQiLXUlW5QW8UlJa5KUMcKaT6J 4k5hHSGyqo7zrJxtjXb4RH5Nw1v7KHKRTEHCAkaogcaZ39W47/t30mlyrdGYre8/dk41Xx v9bVKPtaVjVVFolK5Zdai/KZOdYV3yU7VaS5l/G5VK7v+4x+GI2kq6iZS6WlygohLzRxT3 DBzHig4gdESMp4uzIRjHpHXasWKpNZKW5guBJWnoKa+3pRZayziD9m7nfqCX0w== In-Reply-To: <7518d9d2-138b-d58b-6d95-ef5250093bab@oss.cipunited.com> Content-Transfer-Encoding: 8bit Content-Type: multipart/alternative; boundary=9768797e955dd7860dc9998b53e3a94a457ed74d7cedc87904f890bd0ce2 Cc: User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 References: <7518d9d2-138b-d58b-6d95-ef5250093bab@oss.cipunited.com> X-Lms-Return-Path: From: "Ying Huang" Date: Thu, 01 Jun 2023 17:17:20 +0800 Mime-Version: 1.0 To: , Subject: Re: [PATCH v2] MIPS: Sync elf.h from binutils Message-Id: <13e383ba-2d8b-f9b3-7b93-00113f453c51@oss.cipunited.com> Content-Language: en-US X-Spam-Status: No, score=-1.4 required=5.0 tests=BAYES_00,DKIM_INVALID,DKIM_SIGNED,HTML_MESSAGE,KAM_DMARC_STATUS,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: --9768797e955dd7860dc9998b53e3a94a457ed74d7cedc87904f890bd0ce2 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=UTF-8 Hi, > >/+/* Object attribute tags. */ />/+enum />/+{ />/+ /* 0-3 are generic. *= / />/+ />/+ /* Floating-point ABI used by this object file. */ />/+ Tag_GNU= _MIPS_ABI_FP =3D 4, />/+ />/+ /* MSA ABI used by this object file. */ />/+ = Tag_GNU_MIPS_ABI_MSA =3D 8, />/+}; />/+ />/+/* Object attribute values. */ = />/+enum />/+{ />/+ /* Values defined for Tag_GNU_MIPS_ABI_MSA. */ />/+ />/= + /* Not tagged or not using any ABIs affected by the differences. */ />/+ = Val_GNU_MIPS_ABI_MSA_ANY =3D 0, />/+ />/+ /* Using 128-bit MSA. */ />/+ Val= _GNU_MIPS_ABI_MSA_128 =3D 1, />/+}; / > Any reason for using enum constants here, and not #define? I understand > there is other MIPS precedent, but why continue in this direction? > > Thanks, > Florian =C2=A0=C2=A0=C2=A0 I wish to keep same with binutils. =C2=A0=C2=A0=C2=A0 Thanks, =C2=A0=C2=A0=C2=A0 Ying= --9768797e955dd7860dc9998b53e3a94a457ed74d7cedc87904f890bd0ce2--