From: Mike Frysinger <vapier@gentoo.org>
To: libc-alpha@sourceware.org
Cc: roland@hack.frob.com
Subject: [PATCH] arm: do not abort EABI check for bootstrapping
Date: Thu, 20 Nov 2014 06:32:00 -0000 [thread overview]
Message-ID: <1416468692-4317-1-git-send-email-vapier@gentoo.org> (raw)
The change to simplify the EABI/OABI check from a tuple to a compile test
broke the ability to bootstrap a cross-compiler when generating the glibc
headers. At that point, there is no compiler yet, so this compile-time
test will always fail. Wrap the error with a basic sanity check so that
if the compiler fails, we assume this setup.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
Note: an alternative might be to just delete the EABI check altogether.
It's not like an OABI compiler will be able to properly build glibc ...
sysdeps/arm/preconfigure | 4 ++++
sysdeps/arm/preconfigure.ac | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/sysdeps/arm/preconfigure b/sysdeps/arm/preconfigure
index 59d776d..6a4c84e 100644
--- a/sysdeps/arm/preconfigure
+++ b/sysdeps/arm/preconfigure
@@ -7,9 +7,13 @@ arm*)
cat confdefs.h - <<_ACEOF >conftest.$ac_ext
/* end confdefs.h. */
+/* Do not abort when bootstrapping initial glibc headers -- determine that with
+ a basic sanity check. */
+#ifdef __arm__
#if !__ARM_EABI__
#error
#endif
+#endif
int
main ()
{
diff --git a/sysdeps/arm/preconfigure.ac b/sysdeps/arm/preconfigure.ac
index d78817b..157e822 100644
--- a/sysdeps/arm/preconfigure.ac
+++ b/sysdeps/arm/preconfigure.ac
@@ -4,8 +4,12 @@ GLIBC_PROVIDES dnl See aclocal.m4 in the top level source directory.
case "$machine" in
arm*)
AC_TRY_COMPILE([
+/* Do not abort when bootstrapping initial glibc headers -- determine that with
+ a basic sanity check. */
+#ifdef __arm__
#if !__ARM_EABI__
#error
+#endif
#endif], [], [], [AC_MSG_ERROR([Old ABI no longer supported])])
# If the compiler enables unwind tables by default, this causes
--
2.1.3
next reply other threads:[~2014-11-20 6:32 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-20 6:32 Mike Frysinger [this message]
2014-11-20 17:59 ` Roland McGrath
2014-11-20 18:19 ` Mike Frysinger
2014-11-20 18:36 ` Roland McGrath
2014-11-20 20:08 ` Mike Frysinger
2014-11-20 20:54 ` Roland McGrath
2014-11-20 21:07 ` Joseph Myers
2014-11-20 21:27 ` Mike Frysinger
2014-11-20 21:35 ` Joseph Myers
2014-11-21 10:43 ` Mike Frysinger
2014-11-21 13:12 ` Andreas Schwab
2014-11-20 21:37 ` Roland McGrath
2014-11-20 20:42 ` Joseph Myers
2014-11-20 21:12 ` Mike Frysinger
2014-11-20 22:17 ` [PATCH] arm: wrap EABI check with a cache var Mike Frysinger
2014-11-20 22:52 ` Joseph Myers
2014-11-21 0:06 ` Mike Frysinger
2014-11-21 10:49 ` [PATCH v3] arm: drop EABI check Mike Frysinger
2014-11-21 17:22 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1416468692-4317-1-git-send-email-vapier@gentoo.org \
--to=vapier@gentoo.org \
--cc=libc-alpha@sourceware.org \
--cc=roland@hack.frob.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).