public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
From: Vincent Bernat <Vincent.Bernat@exoscale.ch>
To: libc-alpha@sourceware.org
Cc: Vincent Bernat <vincent@bernat.im>
Subject: [PATCH] time: ensure failing strptime() tests are reported correctly
Date: Fri, 06 Mar 2015 11:02:00 -0000	[thread overview]
Message-ID: <1425639712-28393-1-git-send-email-Vincent.Bernat@exoscale.ch> (raw)
In-Reply-To: <20150306100412.GT12857@vapier>

From: Vincent Bernat <vincent@bernat.im>

---
 ChangeLog            | 6 ++++++
 time/tst-strptime2.c | 5 +----
 time/tst-strptime3.c | 5 +----
 3 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/ChangeLog b/ChangeLog
index 420f351ee0d9..0eb779d91fce 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,9 @@
+2015-03-06  Vincent Bernat  <vincent@bernat.im>
+
+	* time/tst-strptime2.c (do_test): Ensure failing tests are
+	reported correctly.
+	* time/tst-strptime3.c (do_test): Likewise.
+
 2015-03-06  Samuel Thibault  <samuel.thibault@inria.fr>
 
 	Fix aio_error thread-safety.
diff --git a/time/tst-strptime2.c b/time/tst-strptime2.c
index bcd6cc8be98f..a08e6d7cb7de 100644
--- a/time/tst-strptime2.c
+++ b/time/tst-strptime2.c
@@ -52,10 +52,7 @@ do_test (void)
 	}
     }
 
-  if (result == 0)
-    puts ("all OK");
-
-  return 0;
+  return result;
 }
 
 #define TEST_FUNCTION do_test ()
diff --git a/time/tst-strptime3.c b/time/tst-strptime3.c
index 75b57c192871..d53f51ee2244 100644
--- a/time/tst-strptime3.c
+++ b/time/tst-strptime3.c
@@ -48,10 +48,7 @@ do_test (void)
       result = 1;
     }
 
-  if (result == 0)
-    puts ("all OK");
-
-  return 0;
+  return result;
 }
 
 #define TEST_FUNCTION do_test ()
-- 
2.1.4

  reply	other threads:[~2015-03-06 11:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-27 15:20 Vincent Bernat
2015-01-27 16:02 ` [PATCH] time: in strptime(), make %z accept Z as a time zone Vincent Bernat
2015-03-06 10:11   ` Mike Frysinger
2015-01-27 16:03 ` [PATCH] time: in strptime(), make %z accept [+-]HH:MM time zones Vincent Bernat
2015-03-06 10:21   ` Mike Frysinger
2015-03-06 11:06     ` Vincent Bernat
2015-04-20 11:42     ` [BZ #17887][PATCH] " Vincent Bernat
2015-03-06 10:04 ` [PATCH] time: ensure failing strptime() tests are reported correctly Mike Frysinger
2015-03-06 11:02   ` Vincent Bernat [this message]
2015-03-06 11:07     ` Mike Frysinger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1425639712-28393-1-git-send-email-Vincent.Bernat@exoscale.ch \
    --to=vincent.bernat@exoscale.ch \
    --cc=libc-alpha@sourceware.org \
    --cc=vincent@bernat.im \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).