From: "Andreas K. Huettel" <dilfridge@gentoo.org>
To: libc-alpha@sourceware.org
Cc: Florian Weimer <fweimer@redhat.com>
Subject: Re: [PATCH 0/2] Revert "elf: Always call destructors in reverse constructor order (bug 30785)"
Date: Fri, 06 Oct 2023 11:25:23 +0200 [thread overview]
Message-ID: <14293037.dW097sEU6C@noumea> (raw)
In-Reply-To: <cover.1696583991.git.fweimer@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1213 bytes --]
Am Freitag, 6. Oktober 2023, 11:21:24 CEST schrieb Florian Weimer:
> The change does not work with existing applications.
>
I guess we want to revert this on the release branches then too?
> The first revert is an NDEBUG fix which is no longer needed after the
> actual revert.
>
> Tested on i686-linux-gnu and x86_64-linux-gnu.
>
> Thanks,
> Florian
>
> Florian Weimer (2):
> Revert "elf: Fix compile error with -DNDEBUG [BZ #18755]"
> Revert "elf: Always call destructors in reverse constructor order (bug
> 30785)"
>
> elf/dl-close.c | 115 ++++++++++------------------
> elf/dl-fini.c | 152 ++++++++++++++++++++++++-------------
> elf/dl-init.c | 16 ----
> elf/dso-sort-tests-1.def | 19 +++--
> elf/tst-audit23.c | 44 +++++------
> include/link.h | 4 -
> sysdeps/generic/ldsodefs.h | 4 -
> 7 files changed, 174 insertions(+), 180 deletions(-)
>
>
> base-commit: a3c50bf46a1ca6d9d2b7d879176d345abf95a9de
>
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, comrel, toolchain, base-system, perl, libreoffice)
https://wiki.gentoo.org/wiki/User:Dilfridge
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-10-06 9:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-06 9:21 Florian Weimer
2023-10-06 9:21 ` [PATCH 1/2] Revert "elf: Fix compile error with -DNDEBUG [BZ #18755]" Florian Weimer
2023-10-18 8:14 ` Andreas Schwab
2023-10-06 9:21 ` [PATCH 2/2] Revert "elf: Always call destructors in reverse constructor order (bug 30785)" Florian Weimer
2023-10-06 10:37 ` Andreas Schwab
2023-10-06 10:45 ` Florian Weimer
2023-10-18 8:14 ` Andreas Schwab
2023-10-06 9:25 ` Andreas K. Huettel [this message]
2023-10-06 9:30 ` [PATCH 0/2] " Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=14293037.dW097sEU6C@noumea \
--to=dilfridge@gentoo.org \
--cc=fweimer@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).