From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 106247 invoked by alias); 10 Jul 2015 16:41:50 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 106237 invoked by uid 89); 10 Jul 2015 16:41:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 X-HELO: mx1.redhat.com Message-ID: <1436546503.22407.41.camel@localhost.localdomain> Subject: Re: [PATCH v5] Add and use new glibc-internal futex API. From: Torvald Riegel To: Roland McGrath Cc: GLIBC Devel , David Miller Date: Fri, 10 Jul 2015 16:41:00 -0000 In-Reply-To: <20150709224510.6E0632C39DC@topped-with-meat.com> References: <1434987160.25759.26.camel@localhost.localdomain> <20150624232258.9A74C2C3B00@topped-with-meat.com> <1435749621.4216.64.camel@localhost.localdomain> <20150702012747.1EECE2C3ABF@topped-with-meat.com> <1435950241.10077.70.camel@localhost.localdomain> <20150709224510.6E0632C39DC@topped-with-meat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-SW-Source: 2015-07/txt/msg00339.txt.bz2 On Thu, 2015-07-09 at 15:45 -0700, Roland McGrath wrote: > > I've removed the changes to nptl/cancellation.c from this patch because > > I was running into build failures on i686-linux, which happen when calls > > to __libc_fatal() or abort() exist in the code. This seems to happen > > when IS_IN (libc) is true. I don't know why that happens but it seems > > orthogonal to the futex API. Therefore, to move forward with the futex > > API, I choose to simply drop the respective changes from the patch. > > The problem was in the rtld incarnation of that file. It wasn't possible > to use __libc_fatal in rtld. I've just committed a change to fix that. Thanks! > So please put the cancellation.c change back in. Done, and I have committed the patch.