public inbox for libc-alpha@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] alpha: fix fts64 function
@ 2016-03-22 20:03 Aurelien Jarno
  2016-03-28 22:57 ` Roland McGrath
  0 siblings, 1 reply; 2+ messages in thread
From: Aurelien Jarno @ 2016-03-22 20:03 UTC (permalink / raw)
  To: libc-alpha; +Cc: Aurelien Jarno

On wordsize-64 architectures, fts64 is defined as an alias to fts,
because the FTS and FTSENT structures are the same than the FTS64 and
FTSENT64. This is however not true on alpha, where ino_t does not have
the same size than ino64_t.

To fix that, add alpha specific version of fts.c and fts64.c including
io/fts.c and io/fts64.c to have two different versions. This fixes the
io/tst-fts-lfs test.

Changelog:
	* sysdeps/unix/sysv/linux/alpha/fts.c: New file.
	* sysdeps/unix/sysv/linux/alpha/fts64.c: New file.
---
 ChangeLog                             | 5 +++++
 sysdeps/unix/sysv/linux/alpha/fts.c   | 1 +
 sysdeps/unix/sysv/linux/alpha/fts64.c | 1 +
 3 files changed, 7 insertions(+)
 create mode 100644 sysdeps/unix/sysv/linux/alpha/fts.c
 create mode 100644 sysdeps/unix/sysv/linux/alpha/fts64.c

diff --git a/ChangeLog b/ChangeLog
index 36360d9..066b6d9 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,8 @@
+2016-03-22  Aurelien Jarno  <aurelien@aurel32.net>
+
+	* sysdeps/unix/sysv/linux/alpha/fts.c: New file.
+	* sysdeps/unix/sysv/linux/alpha/fts64.c: New file.
+
 2016-03-22  Samuel Thibault  <samuel.thibault@ens-lyon.org>
 
 	* malloc/Makefile ($(objpfx)tst-malloc-backtrace,
diff --git a/sysdeps/unix/sysv/linux/alpha/fts.c b/sysdeps/unix/sysv/linux/alpha/fts.c
new file mode 100644
index 0000000..d0c62e6
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/alpha/fts.c
@@ -0,0 +1 @@
+#include <io/fts.c>
diff --git a/sysdeps/unix/sysv/linux/alpha/fts64.c b/sysdeps/unix/sysv/linux/alpha/fts64.c
new file mode 100644
index 0000000..2472f8b
--- /dev/null
+++ b/sysdeps/unix/sysv/linux/alpha/fts64.c
@@ -0,0 +1 @@
+#include <io/fts64.c>
-- 
2.7.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] alpha: fix fts64 function
  2016-03-22 20:03 [PATCH] alpha: fix fts64 function Aurelien Jarno
@ 2016-03-28 22:57 ` Roland McGrath
  0 siblings, 0 replies; 2+ messages in thread
From: Roland McGrath @ 2016-03-28 22:57 UTC (permalink / raw)
  To: Aurelien Jarno; +Cc: libc-alpha

Rather than special-casing alpha, the logic for whether the aliases can be
used should test __INO_T_MATCHES_INO64_T et al.  It might require inventing
analogous macros for all the LFS-affected types used in FTSENT, but IMHO
that is the right way to do this.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2016-03-28 22:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-03-22 20:03 [PATCH] alpha: fix fts64 function Aurelien Jarno
2016-03-28 22:57 ` Roland McGrath

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).