From: Torvald Riegel <triegel@redhat.com>
To: "Carlos O'Donell" <carlos@redhat.com>
Cc: GNU C Library <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix x86 atomic_fetch_xor_release.
Date: Tue, 18 Oct 2016 11:02:00 -0000 [thread overview]
Message-ID: <1476788563.14800.38.camel@localhost.localdomain> (raw)
In-Reply-To: <1eeffe37-c4ec-fef7-537b-9ad17129b6c0@redhat.com>
On Mon, 2016-10-17 at 23:18 -0400, Carlos O'Donell wrote:
> Torvald,
>
> No code uses atomic_fetch_xor_release except for the upcoming conditional
> variable rewrite. Therefore there is no user visible bug here.
>
> The use of atomic_compare_and_exchange_bool_rel is removed (since it doesn't
> exist anymore), and is replaced by atomic_compare_exchange_weak_release.
>
> We use weak_release because it provides better performance in the loop
> (the weak semantic) and because the xor is release MO (the release semantic).
>
> We don't reload expected in the loop because atomic_compare_and_exchange_weak_release
> does this for us as part of the CAS failure.
>
> It is otherwise a fairly plain conversion that fixes building the new condvar
> for 32-bit x86.
>
> I have pushed the new condvar into Fedora Rawhide for testing.
>
> OK to checkin?
OK.
next prev parent reply other threads:[~2016-10-18 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-18 3:19 Carlos O'Donell
2016-10-18 11:02 ` Torvald Riegel [this message]
2016-10-26 4:04 ` Carlos O'Donell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1476788563.14800.38.camel@localhost.localdomain \
--to=triegel@redhat.com \
--cc=carlos@redhat.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).