From: Steve Ellcey <sellcey@caviumnetworks.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: <libc-alpha@sourceware.org>
Subject: Re: [PATCH] Fix warning from latest GCC in tst-printf.c
Date: Tue, 01 Nov 2016 22:29:00 -0000 [thread overview]
Message-ID: <1478039344.2891.50.camel@caviumnetworks.com> (raw)
In-Reply-To: <alpine.DEB.2.20.1611011736580.21300@digraph.polyomino.org.uk>
On Tue, 2016-11-01 at 17:37 +0000, Joseph Myers wrote:
> On Tue, 1 Nov 2016, Steve Ellcey wrote:
>
> >
> > Ping.  One of the snprintf statements in this test is using a %.999999u
> > format so it is obvious that the test wants to test formats that would
> > go beyond the limit of the snprintf buffer and so we should ignore the
> > warnings in this test.
> OK provided you've tested that this change works with older GCC that lackÂ
> the new option (otherwise it would need to be conditional on the GCCÂ
> version).
I did forget to check it with an older GCC and it does fail with GCC
5.4. Â Here is a new version with a conditional. Â Tested with GCC 5.4
and GCC 7.0 (prerelease).
Ok to checkin?
Steve Ellcey
sellcey@caviumnetworks.com
2016-11-01  Steve Ellcey  <sellcey@caviumnetworks.com>
* stdio-common/tst-printf.c: Ignore -Wformat-length warning.
diff --git a/stdio-common/tst-printf.c b/stdio-common/tst-printf.c
index 2896b18..ffe7ac7 100644
--- a/stdio-common/tst-printf.c
+++ b/stdio-common/tst-printf.c
@@ -32,6 +32,11 @@
    The compiler warnings are not useful here.  */
 DIAG_IGNORE_NEEDS_COMMENT (4.9, "-Wformat");
Â
+#if __GNUC_PREREQ (7, 0)
+/* Compiler warnings about format lengths should also be ignored.  */
+DIAG_IGNORE_NEEDS_COMMENT (7.0, "-Wformat-length");
+#endif
+
 static void rfg1 (void);
 static void rfg2 (void);
 static void rfg3 (void);
next prev parent reply other threads:[~2016-11-01 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-20 22:43 Steve Ellcey
2016-11-01 17:21 ` Steve Ellcey
2016-11-01 17:37 ` Joseph Myers
2016-11-01 22:29 ` Steve Ellcey [this message]
2016-11-01 22:54 ` Joseph Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478039344.2891.50.camel@caviumnetworks.com \
--to=sellcey@caviumnetworks.com \
--cc=joseph@codesourcery.com \
--cc=libc-alpha@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).