From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 86307 invoked by alias); 4 Nov 2016 18:06:46 -0000 Mailing-List: contact libc-alpha-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: libc-alpha-owner@sourceware.org Received: (qmail 86291 invoked by uid 89); 4 Nov 2016 18:06:45 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: NAM01-SN1-obe.outbound.protection.outlook.com Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Message-ID: <1478282790.4630.26.camel@caviumnetworks.com> Subject: Re: [PATCH] Speed up math/test-tgmath2.c From: Steve Ellcey To: Joseph Myers CC: Date: Fri, 04 Nov 2016 18:06:00 -0000 In-Reply-To: References: <1477354555.8523.78.camel@caviumnetworks.com> <1478280156.4630.18.camel@caviumnetworks.com> Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: SN1PR0701CA0052.namprd07.prod.outlook.com (10.163.126.20) To DM2PR0701MB1068.namprd07.prod.outlook.com (10.160.26.21) X-MS-Office365-Filtering-Correlation-Id: f64b02fa-d197-4eb9-33c9-08d404dd4f37 X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB1068;2:OcKulAWhAd06OJ9ZpEJjzW2k0yjz9UMRBKWiTWVHMFt/1DJYVxhCBruGhG5bRZaJVcuVZMlbirxAh0BfDHfXpomkFw9RZEGon/HIBsZv6R074bKBOTCeQ5XWp0EP+NfO/dXU3cqAEaD2Cs6Qm9nc0xcdFTxEibPPrSJym82beXKR6GsRRbbhMP8MYWuSeHhssKrXw3C71BSvnLi2zu/PVg==;3:xUvghQoNW6tgh3th6XXKyb5wCIVAMG0XkkobNUAAxRqFvQPhBqHZ80Eg6bCPSmFGVTXQQGIeTo55kiN4knHrGOKN83P0HxoOhEA0IEeiK/BSqJEV9tjdgZ3ctB+Nxnipv700l8CRXMLvHxRgsuG60g== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0701MB1068; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB1068;25:VP5esum2EWM3ORJJ7I2j3BI+Gf6a9qYhDhmfe3KDqdwcCquf5wBvJtd/IfzvWFzylgPdylZTLqNVFvBiw/DuBW6v4BwnTF7gAESs+enb9D9WEQRKBmVR3J+XUpy5QGxGmE5TNsDpe6wQD5BW4GZMMwfQvI7J3ubZ6qfNtZecbOgZAUWCOrdBMnirCA/3sf6glHGJKiXKYfKBod9H1i/3tiNlU4r4jt9uPTJnaGQ/PmNp6WUs3JmAfdqb7KU1ssNtiWZuZv7VKJec/1kbHWfekzROiG798EWsJR+CNtnolleUC08sbVp5MmXHdUGJwlhihewqLziMEaUpbb4IwODmpZ6tksCBRF3lbCyWxNXhTOEjyO9NC5zk8j8qUM82ryxwPQWghRVwyaW+IKW8FiYqm8y7YxuGO8nDWSGxUJyN3TojP4kckCFZZoIhUxpHngDfzNAlnfOO0VDuZkcBzkcomQXXG5yzPN5upD+ToZKTKedgcFE+14S3iAMuDxEyvHbML87aDEZSDfzg378hXWOWao9Jgww6YU3++fvRUfzuQgsqoUeTlUXGxYPAsEwmHkrMTruzg9v/+tkC7EdXG5ukLrTM0HgZCAw2lW35MOPCy+PbDivaWuxG8mLHQxVBYnCM1KlpTTCaa6aKssjfNL+7AYWxPOKVs4Gifd/RTiPE1JAig35idt0Iat5svPBhs8ab6ej8Ker5+9HrOT0dBY4AfRBavwZTw8Id4EcsXahSx70= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB1068;31:5Wfd7HiqhsBsIZHWaA/SBky8YsSfoU4jJ7FrXU5WJ99wGshWp3ydDRicZaqogVyQHGkTXkVCWM9PfvscKndusvRc1mP9NVy4wNz7FB8O5vLHw/TuetRewA4KZlkDSYPRsBEM+1Hqe1tvYRjC1eS2MffCw+bkzW0Cn/gaXhTzjoegnAKl1uMdM0vNCQorfZ0M1vQMrw1wLahx+M9AVF1XZ1jeNIbspCi4fnrgJyst/4oPCbCqKO5aBrphq+zGzEjXtx8ErocyhkqFcJyI0F3gfg==;20:gG2x1z2mXZ+SlB9pZ5v2D7n5P0MiocFczZNy/sKQvf76pQZ9URFRHJnix89Sepk0X5DT2LwzMpwJZA3g2y/ZGckkq1ZyCToAdC60MvT3ToJSwyyWrh7WNS94Pa6amSnbAkKn5b2LW4keqpt48zuSyFbRc/Z7c3/yN28Z94O4WFOHcHAngNfmjmhKO7B7UA+U9DVMrA9Fgp7PhcB6jiYowL3b1C9wCLakxG9RIHfigMSIek/xgdQRGvTTqaHYoVmQqEpyHpfx25U6/N5bfYRqHJEM1LTsGCSCuIzlq8Pqul7GexoQeQzv+XirZQ2i92ak1f5l+qMR9A78aNkOsrZaSPWFOwTm8Mv2+lu1v4XO4TGcxX/Y4WVtVK3I8hgJPBZKTrzHNxNXfwmPEdHl3oN3trRigKZeugYMPD35h+vX8efcaeM3gJpZjsI+iutty4Mb05OGODQZdsvdOssT7PGEyszun3YZ/Dxbgpba4rTRo8eTjFRicjrBflNKlwAIS5T304tEvOYpb3cSo/JN69+QOQroK7L8fMSoMZTA9KC8Zy2Dibd9w6Gq3cqz6y89jMfOVG08FjbBhvM4jMNINqWYf+b2yN4/+UNVlmD+sDXhnPk= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001);SRVR:DM2PR0701MB1068;BCL:0;PCL:0;RULEID:;SRVR:DM2PR0701MB1068; X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB1068;4:4Tk8UmjCUXBbgmfRqAC3+YCc7tP3r4RnbPsZjqPcdK7AlDrxnW57ygkctiULx/v3FNPC4DgkML82sY4fDoJX6I8nUajpnyKR56tgBh/O7bxdYwLL8ExoqGC12mULhQvjTJEd72Y2shyoHc9zW4J4Q6tQ18MAhpZTMEhF7aktdhcZ8MYXWMo7mMZ8gTAo1pJgF+gP99UZ1EHAii3uiamVqSCGZGmvkhp4VYj8DPKPWPTy7NMRA/eBkWx7WEh5LEFoJT445cWMK0P66FifxDHdtWCr8q1WS/HjNm/z4lDcNIT/P6GEqEJsO2QBzDDhvHSUBFEGfNRUXL/AsR0kIBFJ7zRlSWd/piEC3gvwmTPpkj5HNh3E0lHtlMeJ9zhdEJt4ofRE5NgRUG8rv6Eu8HgMxg== X-Forefront-PRVS: 01165471DB X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(4630300001)(6009001)(7916002)(199003)(377424004)(24454002)(189002)(23676002)(103116003)(97736004)(81156014)(81166006)(68736007)(7736002)(53416004)(7846002)(8676002)(3846002)(6116002)(2906002)(305945005)(586003)(77096005)(47776003)(66066001)(4326007)(19580395003)(19580405001)(50466002)(6916009)(105586002)(42882006)(50986999)(76176999)(2950100002)(69596002)(189998001)(2870700001)(92566002)(5820100001)(5660300001)(106356001)(33646002)(42186005)(110136003)(101416001)(36756003)(50226002)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR0701MB1068;H:sellcey-lt.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTJQUjA3MDFNQjEwNjg7MjM6cE9PL3YvdnFudTRoY3BvQWY0TnpFOXVJ?= =?utf-8?B?TndDaWNNeTk2djRXdHhiNEVlWXc0NHhJRnRia1hCdExyWGVLUmEzM1JERkQ5?= =?utf-8?B?NCtlb202NmV2aGYzeUJJQUZVNERWd25GMHJRVTVmbUVPdUw1M0dKVHQ0VUVw?= =?utf-8?B?UjRZOTA2TmIrbUJtUUwxakNVQWVvc3YzOHd3TXdZZUJEa3FaeFRxaFR2QWdX?= =?utf-8?B?VExTamVGSWYzVEh4Nmo2djFDdGJwUTBDbUIxWTdpak11ZituNTZFK05Mb2Na?= =?utf-8?B?b2VvczlCb3hFMDZYbE1YdXgxeGVVaDduZkdTckpONUNPNnR2b3ZKYW1hZ1Qy?= =?utf-8?B?a2M4bkxCOG9uT1ZLTUtQZnJXSU9LYk92a09LUEhiQlBKWlhHLzQrd0traUU3?= =?utf-8?B?ajhTTzFXNmV1ZWU3aGlzZ28yK21OTXphbFhlR2JtbDh3QVFzWDVsN0ZFYnEv?= =?utf-8?B?VFhNQk5xdU1OTFMwT2VNQ3lJTTBlTFZCQlh4RDBFMlc1RU5ORmtaRHBLeW9V?= =?utf-8?B?K3Ezbk02cFpjTmtZM0g3dnJtUW5vcThSNlhRWXRSTndqNkJ6ekY5NytmN1Ny?= =?utf-8?B?eFZnZnM1ZTNkMDdOSjBESm05SVdabVFIM2Q4S084V3pJbCtqTEMxL3d5Ulkr?= =?utf-8?B?TUdpUWhFL0xwbmgzS0Q2aU1sbkpEQ2t0dmdCTTc1aXd3dW1xRDdYVUpTWDB5?= =?utf-8?B?aGNmNU9Bcks1VUpJK0pqdU5idjJSekh4WUEvV2VIZ3k2NDFBLzZUOW1Ub1l4?= =?utf-8?B?QnU5M0N4RllXb0pTem5Xd2N5anZvT3M3bUZNWTcrd3FMNmpZZlErNFU5S2dQ?= =?utf-8?B?T1p2K2tCU3BabnhObjgxQ2ROZmVnMGtCTURKbVV3OUZGTE84V09nQ05RVVpu?= =?utf-8?B?akt5Sk5BMDJrdUtGNUNXa2hVTFBKWURXdnp1V1gvSTJtdTExNWhzakZSN3hm?= =?utf-8?B?S0VCVE5uSW5tUlo5dGpHQk5HZHRROXJNNDA3UHRiTWxUUndOUWlZMVo3WjNx?= =?utf-8?B?SXRaSTlKa3lFTTlNMCt4Q2hiSTJyNU5nL3RmL1FHVDNOYTkrR1lLSjRxY21U?= =?utf-8?B?bTFmck51S2txQzJuS2JvKzM0anBuWjVTcE5mQyt2TlBYUk1hVVBpdXNZZEJN?= =?utf-8?B?OHZ3cTFscFo3UEVmQ2t5bW9qMnRRSzZqNUEvMlNwL2FacGlMa3lQekNkV3Fz?= =?utf-8?B?Z0E3ZDlQVnhhTzBmUkVwVjZONlRDTDcvSGFkWW5JM0FNd0YzN25tRFhBeUhU?= =?utf-8?B?UVFQTFdsVEtZa1FOMW1GZnBKVVgwcWVQRlNFbDdXYURReGNpRm9oZmtYU3NR?= =?utf-8?B?RzdMMXpNY2Y4MGsyUXZwYzZGZ3ZwNmkvYkNxTnA3ZktxWnFUYnhZZUtMa25P?= =?utf-8?B?RTNXN0hualNhTnVqcnBDSW9wSlQ1eW10MUNYVXpjd21DdldLWVlaenVXaW84?= =?utf-8?B?RzRzSTFhMVlRN1V6dVpQQlN4cW1KMVZvY1c1VWZrcTNuSE1rRU1FVEphTWxY?= =?utf-8?B?ajl3WGVjTlhobWJGSFpkMTZCOHdjaHAvblJBZVhUdUxEMjNIZDNtQldaNjND?= =?utf-8?B?TEs3NjNuWnNEYVgrWWhxamJvZmk5c2tseUtwYkR4VEd1cHQ0TUl6cEZ2MW5w?= =?utf-8?B?N1hjeE83clNRbFBuVFI0YjVZMWE5SzRNL0QzQjN3NFVsdmd5MGNFTytTeXc9?= =?utf-8?Q?=3D?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB1068;6:1ilcHXPuDbX83mLzdWcuyp76VhtG79rtHbEuTOb5EenvbFT6v5csEpfY9JtAlHEvPO2gm6dNrMd4kjVFiJhPhb5+ui7mMNOD4/mbhzqjEtA0VrrmeD80i0uumpznwAMlkvHM0U33QND2aKp+PEj5BKU54RTngQfuL/gRgz1YNhy87JcK+useamxPfPMRkPtNKYUVVPa/VKa0yF7p4mnwFbpnYLrY1c+IhUmz4GUTZnUBBu7fxfgDmst+kUEQJ7o1N4c1XvWudM9Q17S5KUKABZDRjhVl6N28DcdOJyNTE2z5Qbsidkll/xn5ftw75FLz;5:BNwcbywhyvG73/J0ZdcSOxMhH+ftMsOl1QosMubTX9xmWSgI8eq/Jggr+YNUWk/sMW0pSj8IkOw42UzY4tNLuymLKO1rh9d9v8hozizTW7o1RGWHlZC/TS7Fr8s4ZqTnmtlQY1YoUUDyJUVZwIidgA==;24:UA64DZ0YOviU2d0UBv4hhWfMN9CQcO8ReCFOxCu+/rTpiGe9kx0e/fT3zLodkxw3nODsvK9eNji1oAqAaA10zvUrRIwWKt8stbtWeR212w4= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR0701MB1068;7:9v7oeaLfOc+T2pZegyGJ8Y7/i+qGev46vn3PkvRN4yU2wxlrXR32Fui+M8tljOVpUDE0d0tt2C/6DxGs/35w/FJwdUd1t+nZjilqCFFHivG7ICjeIq8Ta+bB12FDvB4aEHuO4UfJiUviZWtrQflDI6qvF2YlKLKHRZS71iZjQd9uS6C9XFmTN5n7kZSU07IfVdeF1ILPogmzBxwGMNvy/Gr3VOaSE9LXN0cOzwySLWspTsnhf7N7fCrscL7um3MpGCDiy7lb+T4cZdCJnK4SKnexBvbddizkYhzK/qaPeu+IZ0IJlABsg1ECcmoNHftS32oCs3NhW5PQe3232kpJnNFItRwHjYvN9yYi8FIhm34= X-OriginatorOrg: caviumnetworks.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 04 Nov 2016 18:06:32.6191 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR0701MB1068 X-SW-Source: 2016-11/txt/msg00193.txt.bz2 On Fri, 2016-11-04 at 17:25 +0000, Joseph Myers wrote: > On Fri, 4 Nov 2016, Steve Ellcey wrote: > > > > > > > > > +  return test_cos (vint1, vllong1) > > > +  + test_fabs (vint1, vllong1) > > > +  + test_conj (vint1, vllong1) > > > +  + test_expm1 (vint1, vllong1) > > > +  + test_lrint (vint1, vllong1) > > > +  + test_ldexp (vint1, vllong1) > > > +  + test_atan2 (vint1, vllong1) > > > +  + test_remquo (vint1, vllong1) > > > +  + test_pow (vint1, vllong1) > > > +  + test_fma_1 (vint1, vllong1) > > > +  + test_fma_2 (vint1, vllong1) > > > +  + test_fma_3 (vint1, vllong1) > > > +  + test_fma_4 (vint1, vllong1); > You don't want to add up test results like that; you should OR them  > together instead, to avoid the potential for test results adding up > to 77 and wrongly becoming UNSUPPORTED.  (In this case of course > there aren't enough tests to get to 77, but the principle applies > that you should avoid the test return being a count of something.) I'll fix that and resubmit.  Is there documentation on what do_test should return?  I looked at test-skeleton.c but there was nothing in there about what do_test/TEST_FUNCTION should return for different results (PASS/FAIL/UNSUPPORTED).  I didn't see anything in the Wiki about return values from do_test either. Steve Ellcey sellcey@caviumnetworks.com